From 3fbd6e61a29a5b3e7e6d34395c95f845b009c817 Mon Sep 17 00:00:00 2001
From: meloalright <meloalright@gmail.com>
Date: Sat, 17 Aug 2024 11:40:25 +0800
Subject: [PATCH 1/3] feat: add progress in vue playground

---
 vue-playground/package.json | 1 +
 vue-playground/src/App.vue  | 6 ++++++
 vue-playground/src/main.ts  | 5 +++++
 3 files changed, 12 insertions(+)

diff --git a/vue-playground/package.json b/vue-playground/package.json
index ad9573d3..c1973e56 100644
--- a/vue-playground/package.json
+++ b/vue-playground/package.json
@@ -14,6 +14,7 @@
     "prismjs": "^1.29.0",
     "vue": "^3.2.13",
     "vue-live": "^2.5.4",
+    "vue3-progress": "0.0.1-beta4",
     "vue-skia": "workspace:*"
   },
   "devDependencies": {
diff --git a/vue-playground/src/App.vue b/vue-playground/src/App.vue
index 6105bbe9..e2b7e17b 100644
--- a/vue-playground/src/App.vue
+++ b/vue-playground/src/App.vue
@@ -1,4 +1,5 @@
 <template>
+  <vue3-progress />
   <main v-if="!loading" style="text-align: center">
     <template v-if="true">
       <h1>Vue Skia</h1>
@@ -113,6 +114,7 @@ import code from "./code";
 import LoadingCode from "./loading-code";
 import "vue-live/style.css";
 import "prism-themes/themes/prism-night-owl.css";
+
 export default defineComponent({
   name: "App",
   components: {
@@ -159,8 +161,12 @@ export default defineComponent({
       }
 
       this.loading = false;
+      (this as unknown as { $progress: { start: () => void; finish: () => void } }).$progress.finish();
     });
   },
+  created() {
+    (this as unknown as { $progress: { start: () => void; finish: () => void } }).$progress.start();
+  },
   methods: {
     input(event: any) {
       this.code = event.target._value;
diff --git a/vue-playground/src/main.ts b/vue-playground/src/main.ts
index d2a4e3fd..4d64d91d 100644
--- a/vue-playground/src/main.ts
+++ b/vue-playground/src/main.ts
@@ -1,7 +1,12 @@
 import { createApp } from "vue";
 import App from "./App.vue";
 import { VueSkia } from 'vue-skia'
+import Vue3Progress from "vue3-progress";
 
 const app = createApp(App);
 app.use(VueSkia);
+app.use(Vue3Progress, {
+    position: "fixed",
+    color: "rgb(0, 161, 132)",
+  })
 app.mount("#app");

From 117dc0e2a32924d543878f3c04e1f78735375c9a Mon Sep 17 00:00:00 2001
From: meloalright <meloalright@gmail.com>
Date: Sat, 17 Aug 2024 12:06:53 +0800
Subject: [PATCH 2/3] feat: add 600 delay

---
 vue-playground/src/App.vue | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/vue-playground/src/App.vue b/vue-playground/src/App.vue
index e2b7e17b..6d34288c 100644
--- a/vue-playground/src/App.vue
+++ b/vue-playground/src/App.vue
@@ -20,6 +20,7 @@
         </div>
         <VueLive
           :editorProps="{ lineNumbers: true }"
+          :delay="600"
           :code="!loading && !debug ? code : LoadingCode"
           :layout="CustomLayout"
           :components="{
@@ -169,7 +170,7 @@ export default defineComponent({
   },
   methods: {
     input(event: any) {
-      this.code = event.target._value;
+      // this.code = event.target._value;
     },
     copy() {
       try {

From 0a9aac4503f79553a4a435ec31c9f09ee5307295 Mon Sep 17 00:00:00 2001
From: meloalright <meloalright@gmail.com>
Date: Sat, 17 Aug 2024 13:23:29 +0800
Subject: [PATCH 3/3] feat: check attached and isMounted

---
 vue-skia-framework/plugin/index.ts | 7 ++++++-
 vue-skia-framework/type.ts         | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/vue-skia-framework/plugin/index.ts b/vue-skia-framework/plugin/index.ts
index 8e3182b7..5bb4f26b 100644
--- a/vue-skia-framework/plugin/index.ts
+++ b/vue-skia-framework/plugin/index.ts
@@ -64,6 +64,7 @@ const VSKNode = (name: string) => {
             instance._ssw_id = (
               parent as ComponentInternalInstanceWithSoftSkiaWASM
             )._ssw_id;
+            instance._ssw_attached = true;
 
             instance._ssw_grouped = (child) => {
               core.setAttrBySerde(instance._ssw_id, {
@@ -103,6 +104,7 @@ const VSKNode = (name: string) => {
                 }
                 const core = root.ssw;
                 instance._ssw_id = SelfIncreaseCount.count;
+                instance._ssw_attached = true;
                 var parent = instance.parent;
                 while (!('_ssw_id' in parent)) {
                     parent = parent.parent;
@@ -208,7 +210,10 @@ const VSKNode = (name: string) => {
                 while (!('_ssw_id' in parent)) {
                     parent = parent.parent;
                 }
-                core.removeChildFromContainer(child_id, (parent as ComponentInternalInstanceWithSoftSkiaWASM)._ssw_id)
+                instance._ssw_attached = false;
+                if ((parent as ComponentInternalInstanceWithSoftSkiaWASM)._ssw_attached && parent.isMounted) {
+                  core.removeChildFromContainer(child_id, (parent as ComponentInternalInstanceWithSoftSkiaWASM)._ssw_id)
+                }
             });
 
             return () => h(name, {}, slots.default?.())
diff --git a/vue-skia-framework/type.ts b/vue-skia-framework/type.ts
index 82a975a2..b1259a34 100644
--- a/vue-skia-framework/type.ts
+++ b/vue-skia-framework/type.ts
@@ -6,6 +6,7 @@ import { SoftSkiaWASM } from '../soft-skia-wasm/pkg/';
 export type ComponentInternalInstanceWithSoftSkiaWASM = ComponentInternalInstance & {
     ssw: SoftSkiaWASM;
     _ssw_id: number;
+    _ssw_attached: boolean;
     _ssw_grouped?: (instance: ComponentInternalInstanceWithSoftSkiaWASM) => void;
     _ssw_batchDraw?: () => void;
 }