Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust GitHub Actions in actions-rs seem unmaintained #2

Closed
oherrala opened this issue Dec 22, 2022 · 5 comments
Closed

Rust GitHub Actions in actions-rs seem unmaintained #2

oherrala opened this issue Dec 22, 2022 · 5 comments

Comments

@oherrala
Copy link

oherrala commented Dec 22, 2022

This is not a Rust crate, but tooling used by many Rust projects. Is this correct place to discuss and maybe take action on informing community about the issue?

The actions-rs GitHub Actions from GitHub (https://github.com/actions-rs) is used by many Rust projects.

However, the actions don't see much love, there's discussion about the maintenance status here: actions-rs/meta#43

As these actions are not maintained a known vulnerabilities might start to pile up and things might start to break because GitHub is deprecating support for some thing (e.g. actions-rs#227).

Pinging @svartalf since he's the (only?) owner of the GitHub organization.

@oherrala
Copy link
Author

Quoting @svartalf from actions-rs/cargo#59 (comment):

Before you ask about adding more maintainers, I thought about it for a long time, but since https://github.com/actions-rs are used heavily both by companies and individuals at this point for both public and private repos, there is a huge trust issue we should take into the consideration, because having a write access to these repositories provides a huge attack vector too.
I prefer to keep these repos stale for now rather then accidentally allowing some malicious third party to get access to all these private repos, which will be way worse than not having some feature merged.

@pinkforest
Copy link

pinkforest commented Dec 23, 2022

While back audit-check was forked into RustSec
https://github.com/rustsec/audit-check - Issues / PR's welcome

Yeah there is really no way for us to generate notice via advisory-db as this one is just GitHub action thing.

But we have some contacts with GitHub we can ask around.

Moving the issue to RustSec/audit-check

@pinkforest pinkforest transferred this issue from rustsec/advisory-db Dec 23, 2022
@tarcieri
Copy link
Member

I think we could probably put together a much simpler action for people to use, which doesn't depend on e.g. Node.js in any way

@jonasbb
Copy link

jonasbb commented Jan 5, 2023

Some time ago, I wrote https://github.com/actions-rust-lang/audit to move off actions-rs. It is written as a composite action with the main logic in Python instead of JavaScript. It supports maintaining issues and writes a workflow summary with the findings. It doesn't really provide more features than audit-check except for an explicit input argument to ignore IDs.
I am happy to talk more about it in case you find it of any interest.

@pinkforest
Copy link

This action now uses node16 and dependencies have been bumped so should be perfectly usable.
It's fairly simple in the end - can continue altearntives in discussions if there is really need.

hawkw pushed a commit to tokio-rs/console that referenced this issue Jan 7, 2024
)

- Update actions/checkout, arduino/setup-protoc, and
  taiki-e/create-gh-release-action actions.
- Replace unmaintained actions-rs/audit-check action with
  rustsec/audit-check action (rustsec fork of actions-rs/audit-check.
  see also rustsec/audit-check#2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants