Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement functions from position/game_math for RoomXY #498

Closed
shanemadden opened this issue Feb 22, 2024 · 2 comments
Closed

Implement functions from position/game_math for RoomXY #498

shanemadden opened this issue Feb 22, 2024 · 2 comments
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.

Comments

@shanemadden
Copy link
Collaborator

RoomXY should have equivalent functionality to Position for in-room stuff that we can do fully within native math. All of the functions from the game_math module would make sense on the RoomXY type.

Potentially as an enhancement, both types could use a manhattan range function in addition to the current chebyshev range function. Maybe we should even go as far as providing a euclidean range function?
@shanemadden shanemadden added the C-enhancement Category: A PR with an enhancement or a proposed on in an issue. label Feb 22, 2024
@shanemadden
Copy link
Collaborator Author

Should add some of these to RoomName too

@shanemadden
Copy link
Collaborator Author

Resolved by #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shanemadden