From 92181860dd8307f763d33657a8701963583f099e Mon Sep 17 00:00:00 2001 From: Renan Rangel Date: Mon, 23 Sep 2024 03:49:44 -0700 Subject: [PATCH] PR feedback Signed-off-by: Renan Rangel --- changelog/21.0/21.0.0/summary.md | 4 ++-- go/vt/mysqlctl/mysqlshellbackupengine.go | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/changelog/21.0/21.0.0/summary.md b/changelog/21.0/21.0.0/summary.md index b17cfb890eb..f314a0be8df 100644 --- a/changelog/21.0/21.0.0/summary.md +++ b/changelog/21.0/21.0.0/summary.md @@ -135,10 +135,10 @@ Example usage: ### New Backup Engine (EXPERIMENTAL) -We are introducing a the backup engine supporting logical backups starting on v21 to support use cases that require something else besides physical backups. This is experimental and is based on the +We are introducing a backup engine supporting logical backups starting on v21 to support use cases that require something else besides physical backups. This is experimental and is based on the [MySQL Shell](https://dev.mysql.com/doc/mysql-shell/8.0/en/). -The new engine is enabled by using `--backup_engine_implementation=mysqlshell`. There are other options that are required, so check the docs on which options are required and how to use it. +The new engine is enabled by using `--backup_engine_implementation=mysqlshell`. There are other options that are required, so [check the docs](https://vitess.io/docs/21.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup/) on which options are required and how to use it. ### Dynamic VReplication Configuration Currently many of the configuration options for VReplication Workflows are vttablet flags. This means that any change diff --git a/go/vt/mysqlctl/mysqlshellbackupengine.go b/go/vt/mysqlctl/mysqlshellbackupengine.go index d1a7bd0fee0..38dccc8c622 100644 --- a/go/vt/mysqlctl/mysqlshellbackupengine.go +++ b/go/vt/mysqlctl/mysqlshellbackupengine.go @@ -85,6 +85,8 @@ type MySQLShellBackupManifest struct { } func init() { + BackupRestoreEngineMap[mysqlShellBackupEngineName] = &MySQLShellBackupEngine{} + for _, cmd := range []string{"vtcombo", "vttablet", "vtbackup", "vttestserver", "vtctldclient"} { servenv.OnParseFor(cmd, registerMysqlShellBackupEngineFlags) } @@ -578,7 +580,3 @@ func cleanupMySQL(ctx context.Context, params RestoreParams, shouldDeleteUsers b return err } - -func init() { - BackupRestoreEngineMap[mysqlShellBackupEngineName] = &MySQLShellBackupEngine{} -}