Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash at ScriptLanguage::_evaluate_watches due to nullptr dereference #3

Closed
rxlecky opened this issue Nov 9, 2019 · 2 comments
Closed
Assignees
Labels

Comments

@rxlecky
Copy link
Owner

rxlecky commented Nov 9, 2019

Expression::execute is getting called when there was a parse error causing the editor to crash.

@rxlecky rxlecky added the crash label Nov 9, 2019
@rxlecky rxlecky self-assigned this Nov 9, 2019
@rxlecky
Copy link
Owner Author

rxlecky commented Nov 9, 2019

I've misinterpreted the stacktrace from JavaryGames#1 (comment). Reading it again now, the cause of the crash seems to be a nullptr dereference at https://github.com/rxlecky/godot/blob/3ac33d0ea0ca8fd8acf6bc9f707f41b7a0d368c8/core/script_language.cpp#L503

@rxlecky
Copy link
Owner Author

rxlecky commented Nov 9, 2019

@jahd2602 I added null checks to where this issue seems to be coming from. The crash shouldn't be happening anymore so I'm closing this now.

Could you be on a lookout for ERROR: Parameter is null. in your console so we can eventually fix wherever the nullptr is coming from?

@rxlecky rxlecky closed this as completed Nov 9, 2019
@rxlecky rxlecky changed the title Crash at Expression::execute when using watches Crash at ScriptLanguage::_evaluate_watches due to nullptr dereference Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant