Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed proxy being ignored #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

Fixed proxy being ignored #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,10 @@ type apiStatus struct {

// Init setup the apiKey
func Init(config Config) *TMDb {
internalConfig := new(tmdbConfig)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this line? It looks like only the other change is actually needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this internalConfig useless，Even if you don't delete it, it won't have any impact.Of course, the best way is for each client to initialize and maintain the proxy information by itself, but it is OK if the library provides a default.

if config.UseProxy == true && len(config.Proxies) > 1 {
internalConfig.useProxy = config.UseProxy
internalConfig.proxies = prepareProxies(config.Proxies)
internalConfig.roundRobin = InitRoundRobin(len(internalConfig.proxies))
internalConfig.roundRobin = InitRoundRobin(len(internalConfig.proxies) - 1)
}

return &TMDb{apiKey: config.APIKey}
Expand Down