Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Comments #3

Open
ryanbthomas opened this issue Nov 7, 2019 · 2 comments
Open

Ignore Comments #3

ryanbthomas opened this issue Nov 7, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
0.2.0

Comments

@ryanbthomas
Copy link
Owner

Currently scan_file includes lines where hazards are in comments, which may not be necessary.
@ryanbthomas
Copy link
Owner Author

Questions:

  1. Can this be done by just modifying the regexp used?
  2. Does it require a secondary step to test from presence of a '#'

@ryanbthomas ryanbthomas added this to the 0.2.0 milestone Nov 14, 2019
@ryanbthomas ryanbthomas added the enhancement New feature or request label Nov 14, 2019
@ryanbthomas
Copy link
Owner Author

Possible implementation:

add ignore_comments argument to scan_file function / which would be passed in turn to identify_hazard. If true, then identified lines are scanned for a comment '#' which proceeds the hazard.

This implementation seems simpler than trying to update the regexp to have a negative look-behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@ryanbthomas