Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for alternative mod distribution platforms #97

Open
EldraTheThird opened this issue Jan 27, 2023 · 3 comments
Open

Support for alternative mod distribution platforms #97

EldraTheThird opened this issue Jan 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@EldraTheThird
Copy link

Mods other than CurseForge/Modrinth (like Thymine Mod, etc) are not added when creating modpack

To test it, I tried creating a modpack on Prism Launcher

  1. First add Thymine and mods not available on Modrinth/CurseForge
  2. Export it to a .zip file and select MultiMC/Prism instance
  3. Select the exported zip file, name it and click Submit. And you will see some mods not fully displayed

Screenshots
Moddermore's mods list showing
image
And here is the list of mods included in Prism Launcher
image
You can be pretty clear that Thymine is still visible in Prism, but not in Moddermore :/

Desktop

  • OS: Windows 10 Home SL
  • Browser: CocCoc 114.0.140 64bit
  • Version: 114.0.140 64bit

I think it is advisable to add scanning for mods from other sources, this will diversify the number of mods in the modpack
And I really like Moddermore :D Because it helps me make modpack much faster than ATLauncher (and more convenient when this is a website)

@EldraTheThird EldraTheThird added bug Something isn't working help wanted Extra attention is needed labels Jan 27, 2023
@ryanccn ryanccn changed the title Mods are not sourced from Modrinth/CurseForge (maybe from 9minecraft, GitHub,...) Support for alternative mod distribution platforms Jan 28, 2023
@ryanccn
Copy link
Owner

ryanccn commented Jan 28, 2023

A few of these have been considered in the past.

  • 9minecraft is known for illegal redistributing mods and other content without original authors' consent and is not trustworthy either, so it will not be supported.
  • GitHub support was originally planned, but there is no unified format for game version and mod loader information. This would result in a quite painful user experience even if added.
  • Custom file uploads is something I am thinking about, but the associated risks with malware, piracy and such are something I still have to consider.

@ryanccn
Copy link
Owner

ryanccn commented Jan 28, 2023

Perhaps for GitHub I can make a dialog for the user to select a particular version and a particular release asset, but that will obviously take some time to develop 🤔

@EldraTheThird
Copy link
Author

Quite interestingly, Thymine 1.18x version and some stuff in the "index" folder show up fully when I do it on Moddermore (could be a coincidence :/ but I'm pretty happy because I finished it before (actually during) Lunar New Year)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants