Make comments render methods hookable

[gebeer]

Please make the render functions for the comments list and item in CommentList.php hookable.
I need microdata in the markup for the comment lists ratings. I know I could loop through the comments and output my own markup. But it would be much better if I could place this in a module and hook from there as I (and maybe others) sure could use this on other projects, too.
See also forum tread
Thank you.
I added a pull request for master

[LostKobrakai]

What about not replacing the method, but adding a custom one?

$wire->addHook('CommentList::renderWithMicrodata', function($e){ … });

Most of the class's methods are public anyways.

[gebeer]

haven't thought about that. But now you point me to it, it seems like a great idea ;)

Are those methods not hookable for a certain reason?

[ryancramerdesign]

Are those methods not hookable for a certain reason?

We don't usually make methods hookable unless there's a definite need for it. That's because there's more overhead in calling a hookable method vs. a non-hookable method. However, after looking at LostKobrakai's suggestion, if you find that you still need these methods to be hookable, just let me know.

[gebeer]

Thank you, Ryan, for clarifying. I think I can do with LostKobraKai's suggestion. So there isn't really a need to make those methods hookable and you can close this issue.