Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProcessFieldExportImport] Long Functions (?) #2064

Open
LimeWub opened this issue Oct 2, 2017 · 0 comments
Open

[ProcessFieldExportImport] Long Functions (?) #2064

LimeWub opened this issue Oct 2, 2017 · 0 comments

Comments

@LimeWub
Copy link

LimeWub commented Oct 2, 2017

Hello there :)

This is more of a question than an issue.

I am currently working on a module to import a set of preset templates/fields for every new PW installation; so as to speed up development time at the beginning of a project.

I am looking into the wire/ProcessTemplate/ProcessTemplateExportImport.php (and the ProcessField equivalent) and I can see I could make use of some of the functionality in there -in particular ___buildImport() -.

However, this function expects get and post input to work.
I think if I were to provide a json string instead (as a method parameter) this should be working fine. Am I wrong to think that?
Looking at the method it's also 150-ish lines long.

Basically is there a reason this is one method or would it be ok for me to break it down into at least 2 (Data Aquisition + Processing) methods and commit this back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant