-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cobertura Status Bar Percentage Wrong with C# Workspace #437
Comments
@terryaney Thanks for the ticket and the logs from the extension output. We should probably have more logging in this area of the code to assist with debugging your issues, just looking at the source code doesn't reveal anything immediately. public setCoverage(linePercentage: number | undefined ) {
if (Number.isFinite(linePercentage)) {
this.lineCoverage = `${linePercentage}%`;
} else {
this.lineCoverage = undefined;
}
this.update();
} Do you know if it is all files within your codebase or just a subset? |
Unfortunately, it appears not. I wrote a few unit tests to test extension methods in one project and it seemed to display % correctly, but another few simple extension method tests in another project didn't work (second reference above where I mention the 'opposite was happening with
Anyway to turn on meaningful logging I can give you? |
Sadly, no current way to introduce more logging easily (via an extension setting lets say). https://github.com/ryanluker/vscode-coverage-gutters/blob/master/src/extension.ts#L8-L17 |
I'll wait :) My VS Code extension experience is close to NIL. Thanks for update. |
No worries, I always like to at least present the option, as sometimes people have expectations for how long a bug might take to fix. |
If I use
lcov
coverage format, everything seems to work. When usingcobertura
, the status bar percentage is wrong. Here iscobertura
screen shot:Approve.cs
file is in the correct project/folder that tests were ran on and that there is only acoverage.cobertura.xml
file present.If I change the
lcov
format, everything seems to display correctly:Let me know if I can provide any more info. Thanks.
The text was updated successfully, but these errors were encountered: