Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official uncrustify default config file fails to import #11

Open
JanX2 opened this issue Nov 8, 2013 · 4 comments
Open

Official uncrustify default config file fails to import #11

JanX2 opened this issue Nov 8, 2013 · 4 comments

Comments

@JanX2
Copy link

JanX2 commented Nov 8, 2013

The official uncrustify default config file fails to import:

An error occurred during import
The value 'ignore' is not valid for the number value type required for the sp_before_template_paren option

@ryanmaxwell
Copy link
Owner

This would indicate to me an issue with the official config file rather than a fault with the app. A basic validation is performed on the options based on their type during import - and i've noticed errors in the "official" config files before with respect to values and duplicate definitions.

@JanX2
Copy link
Author

JanX2 commented Nov 9, 2013

Just as with issue #10, it may not be the best way to just curl up and die. :)

@ryanmaxwell
Copy link
Owner

agreed. I'll change the failure to a warning that can be overridden

@ryanmaxwell ryanmaxwell reopened this Nov 9, 2013
@JanX2
Copy link
Author

JanX2 commented Nov 9, 2013

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants