Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration for spring 4 #9

Open
yeyanzhao opened this issue Nov 2, 2014 · 5 comments
Open

integration for spring 4 #9

yeyanzhao opened this issue Nov 2, 2014 · 5 comments

Comments

@yeyanzhao
Copy link

I integrate this to spring mvc 4.1 successfully today.
And there need some changing for migrating to spring 4.1 from 3.*, because one new method [ configurePathMatch ] has been added to interface WebMvcConfigurer need be implemented by RythmConfigure class in [spring-rythm] project.
So there may be a new branch for spring since 4.0.3.
I just add a simple implementation like below:
@OverRide
public void configurePathMatch(PathMatchConfigurer configurer) {
}

@Vest
Copy link

Vest commented Nov 13, 2016

Hi @greenlaw110,

are there any updates on this issue? There is the project that uses rythm with Spring 4, and I plan to drop the rythm support, because of this two years old issue.

Thanks.

@Digital-Chaos
Copy link
Contributor

Digital-Chaos commented Mar 18, 2017

To get working with Spring 4.3.7 some more methods need to be implemented in the RythmConfigurer class;

@Override
public void configurePathMatch(PathMatchConfigurer configurer) {
}

@Override
public void extendMessageConverters(List<HttpMessageConverter<?>> var1){
}

@Override
public void addCorsMappings(CorsRegistry var1){
}

@Override
public void extendHandlerExceptionResolvers(List<HandlerExceptionResolver> var1){
}

@Override
public void configureViewResolvers(ViewResolverRegistry registry){
}

@greenlaw110
Copy link
Collaborator

@Digital-Chaos Do you mind submitting a PR to me?

@Digital-Chaos
Copy link
Contributor

Digital-Chaos commented Mar 22, 2017

Done, but not sure how we are going to maintain Spring 3 compatibility (if at all).

@greenlaw110
Copy link
Collaborator

greenlaw110 commented Mar 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants