-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration for spring 4 #9
Comments
Hi @greenlaw110, are there any updates on this issue? There is the project that uses rythm with Spring 4, and I plan to drop the rythm support, because of this two years old issue. Thanks. |
To get working with Spring 4.3.7 some more methods need to be implemented in the RythmConfigurer class;
|
@Digital-Chaos Do you mind submitting a PR to me? |
Done, but not sure how we are going to maintain Spring 3 compatibility (if at all). |
Thanks @Digital-Chaos, my guess is we can keep Spring 3 maintained to a
separate branch and use version to distinct between spring 4 and spring 3.
Unfortunately I am really busy at the moment. I will try to get this sorted
out by the end of next week
…On Thu, Mar 23, 2017 at 7:50 AM Digital-Chaos ***@***.***> wrote:
Done, but not sure how we are going to maintain Spring 3 compatibility.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANPYg8BfvWaOK_hDWt5uO_kYyKcCnEgks5roYmngaJpZM4C2ALH>
.
|
I integrate this to spring mvc 4.1 successfully today.
And there need some changing for migrating to spring 4.1 from 3.*, because one new method [ configurePathMatch ] has been added to interface WebMvcConfigurer need be implemented by RythmConfigure class in [spring-rythm] project.
So there may be a new branch for spring since 4.0.3.
I just add a simple implementation like below:
@OverRide
public void configurePathMatch(PathMatchConfigurer configurer) {
}
The text was updated successfully, but these errors were encountered: