Formalise Lemmas 10.7 and 10.8 from RS17 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me thus far! Let us know if you want this merged and complete the other propositions in a separate PR :) |
|
Let's merge this now and you can submit a new pull request with the new results whenever they're ready. @dvmcarpena you've done a great job with the style guide. But I renamed both of your terms. There are a few similar results in the covariant families file that @fredrik-bakke suggested we name "compute-thing-we're-computing-list-of-hypotheses". So I've attempted to follow that convention. Please feel free to suggest alternate names with your next pull request also. I don't have a strong sense yet of how things should go! |
emilyriehl
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution to issue #24. I'm trying also to do the other two propositions to close the issue, but seem a little more involved.