support adding settings-path for settings.xml #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @slawekjaranowski , |
slawekjaranowski
requested changes
Oct 29, 2024
Hello @slawekjaranowski , |
slawekjaranowski
previously approved these changes
Nov 3, 2024
robot-simplify4u
approved these changes
Nov 3, 2024
slawekjaranowski
approved these changes
Nov 3, 2024
slawekjaranowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we know that the setup-maven-action uses the settings-maven-action https://github.com/marketplace/actions/maven-settings-action , I have checked the settings-action and inside the action.yaml file there is an attribute for path to override the settings.xml file, I would like to request a support for adding the path attribute.