Merge pull request wintersrd#85 from s7clarke10/bug/fix_escaping_for_table_lsn_function

mjsqu · web-flow · commit b82bafb5ad52 · 2024-10-09T16:02:37.000+13:00
Passing in a non-escaped table to the lsn lookup function
diff --git a/.bumpversion.cfg b/.bumpversion.cfg
@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 2.6.0
+current_version = 2.6.1
 parse = (?P<major>\d+)
 	\.(?P<minor>\d+)
 	\.(?P<patch>\d+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# tap-mssql 2.6.1 2024-10-09
+* Resolving issue with call get the prior LSN number (passing in unescaped table).
+
 # tap-mssql 2.6.0 2024-09-02
 * Resolving issue LOG_BASED tables with special characters. Escaping the object
   names with double quotes. Issue #74
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "tap-mssql"
-version = "2.6.0"
+version = "2.6.1"
 description = "A pipelinewise compatible tap for connecting Microsoft SQL Server"
 authors = ["Rob Winters <wintersrd@gmail.com>"]
 license = "GNU Affero"
diff --git a/tap_mssql/sync_strategies/log_based.py b/tap_mssql/sync_strategies/log_based.py
@@ -311,7 +311,7 @@ def sync_table(mssql_conn, config, catalog_entry, state, columns, stream_version
                     ).format(escaped_schema_name, escape_table_name)
                 )
 
-            lsn_range = get_lsn_available_range(mssql_conn, escaped_cdc_table)
+            lsn_range = get_lsn_available_range(mssql_conn, cdc_table)
 
             if lsn_range[0] is not None:  # Test to see if there are any change records to process
                 lsn_from = str(lsn_range[0].hex())

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ def sync_table(mssql_conn, config, catalog_entry, state, columns, stream_version`
`311`	`311`	`).format(escaped_schema_name, escape_table_name)`
`312`	`312`	`)`
`313`	`313`
`314`		`- lsn_range = get_lsn_available_range(mssql_conn, escaped_cdc_table)`
	`314`	`+ lsn_range = get_lsn_available_range(mssql_conn, cdc_table)`
`315`	`315`
`316`	`316`	`if lsn_range[0] is not None: # Test to see if there are any change records to process`
`317`	`317`	`lsn_from = str(lsn_range[0].hex())`