fix: remove MetadataUpdate event from renounce functions

docs: add MetadataUpdate event in create functions natspecs

src/abstracts/SablierLockupBase.sol

@@ -357,9 +357,6 @@ abstract contract SablierLockupBase is
 
         // Log the renouncement.
         emit ISablierLockupBase.RenounceLockupStream(streamId);
-
-        // Emit an ERC-4906 event to trigger an update of the NFT metadata.
-        emit MetadataUpdate({ _tokenId: streamId });
     }
 
     /// @inheritdoc ISablierLockupBase

src/interfaces/ISablierLockup.sol

@@ -82,7 +82,7 @@ interface ISablierLockup is ISablierLockupBase {
     /// `block.timestamp` and all specified time durations. The segment timestamps are derived from these
     /// durations. The stream is funded by `msg.sender` and is wrapped in an ERC-721 NFT.
     ///
-    /// @dev Emits a {Transfer} and {CreateLockupDynamicStream} event.
+    /// @dev Emits a {Transfer}, {CreateLockupDynamicStream}, and {MetadataUpdate} event.
     ///
     /// Requirements:
     /// - All requirements in {createWithTimestampsLD} must be met for the calculated parameters.
@@ -103,7 +103,7 @@ interface ISablierLockup is ISablierLockupBase {
     /// the sum of `block.timestamp` and `durations.total`. The stream is funded by `msg.sender` and is wrapped in an
     /// ERC-721 NFT.
     ///
-    /// @dev Emits a {Transfer} and {CreateLockupLinearStream} event.
+    /// @dev Emits a {Transfer}, {CreateLockupLinearStream}, and {MetadataUpdate} event.
     ///
     /// Requirements:
     /// - All requirements in {createWithTimestampsLL} must be met for the calculated parameters.
@@ -126,7 +126,7 @@ interface ISablierLockup is ISablierLockupBase {
     /// `block.timestamp` and all specified time durations. The tranche timestamps are derived from these
     /// durations. The stream is funded by `msg.sender` and is wrapped in an ERC-721 NFT.
     ///
-    /// @dev Emits a {Transfer} and {CreateLockupTrancheStream} event.
+    /// @dev Emits a {Transfer}, {CreateLockupTrancheStream}, and {MetadataUpdate} event.
     ///
     /// Requirements:
     /// - All requirements in {createWithTimestampsLT} must be met for the calculated parameters.
@@ -146,7 +146,7 @@ interface ISablierLockup is ISablierLockupBase {
     /// @notice Creates a stream with the provided segment timestamps, implying the end time from the last timestamp.
     /// The stream is funded by `msg.sender` and is wrapped in an ERC-721 NFT.
     ///
-    /// @dev Emits a {Transfer} and {CreateLockupDynamicStream} event.
+    /// @dev Emits a {Transfer}, {CreateLockupDynamicStream}, and {MetadataUpdate} event.
     ///
     /// Notes:
     /// - As long as the segment timestamps are arranged in ascending order, it is not an error for some
@@ -180,7 +180,7 @@ interface ISablierLockup is ISablierLockupBase {
     /// @notice Creates a stream with the provided start time and end time. The stream is funded by `msg.sender` and is
     /// wrapped in an ERC-721 NFT.
     ///
-    /// @dev Emits a {Transfer} and {CreateLockupLinearStream} event.
+    /// @dev Emits a {Transfer}, {CreateLockupLinearStream}, and {MetadataUpdate} event.
     ///
     /// Notes:
     /// - A cliff time of zero means there is no cliff.
@@ -218,7 +218,7 @@ interface ISablierLockup is ISablierLockupBase {
     /// @notice Creates a stream with the provided tranche timestamps, implying the end time from the last timestamp.
     /// The stream is funded by `msg.sender` and is wrapped in an ERC-721 NFT.
     ///
-    /// @dev Emits a {Transfer} and {CreateLockupTrancheStream} event.
+    /// @dev Emits a {Transfer}, {CreateLockupTrancheStream}, and {MetadataUpdate} event.
     ///
     /// Notes:
     /// - As long as the tranche timestamps are arranged in ascending order, it is not an error for some

src/interfaces/ISablierLockupBase.sol

@@ -228,7 +228,7 @@ interface ISablierLockupBase is
 
     /// @notice Burns the NFT associated with the stream.
     ///
-    /// @dev Emits a {Transfer} event.
+    /// @dev Emits a {Transfer}, and {MetadataUpdate} event.
     ///
     /// Requirements:
     /// - Must not be delegate called.
@@ -279,7 +279,7 @@ interface ISablierLockupBase is
 
     /// @notice Removes the right of the stream's sender to cancel the stream.
     ///
-    /// @dev Emits a {RenounceLockupStream} and {MetadataUpdate} event.
+    /// @dev Emits a {RenounceLockupStream} event.
     ///
     /// Notes:
     /// - This is an irreversible operation.
@@ -295,7 +295,7 @@ interface ISablierLockupBase is
 
     /// @notice Renounces multiple streams.
     ///
-    /// @dev Emits multiple {RenounceLockupStream} and {MetadataUpdate} events.
+    /// @dev Emits multiple {RenounceLockupStream} events.
     ///
     /// Notes:
     /// - Refer to the notes in {renounce}.
@@ -357,7 +357,7 @@ interface ISablierLockupBase is
     /// @notice Withdraws the maximum withdrawable amount from the stream to the current recipient, and transfers the
     /// NFT to `newRecipient`.
     ///
-    /// @dev Emits a {WithdrawFromLockupStream} and a {Transfer} event.
+    /// @dev Emits a {WithdrawFromLockupStream}, {Transfer} and {MetadataUpdate} event.
     ///
     /// Notes:
     /// - If the withdrawable amount is zero, the withdrawal is skipped.

tests/integration/concrete/lockup-base/renounce-multiple/renounceMultiple.t.sol

@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: UNLICENSED
 pragma solidity >=0.8.22 <0.9.0;
 
-import { IERC4906 } from "@openzeppelin/contracts/interfaces/IERC4906.sol";
 import { Solarray } from "solarray/src/Solarray.sol";
 
 import { ISablierLockupBase } from "src/interfaces/ISablierLockupBase.sol";
@@ -90,15 +89,11 @@ contract RenounceMultiple_Integration_Concrete_Test is Integration_Test {
         givenNoColdStreams
         whenCallerAuthorizedForAllStreams
     {
-        // It should emit {MetadataUpdate} and {RenounceLockupStream} events for both the streams.
+        // It should emit {RenounceLockupStream} events for both the streams.
         vm.expectEmit({ emitter: address(lockup) });
         emit ISablierLockupBase.RenounceLockupStream(streamIds[0]);
         vm.expectEmit({ emitter: address(lockup) });
-        emit IERC4906.MetadataUpdate({ _tokenId: streamIds[0] });
-        vm.expectEmit({ emitter: address(lockup) });
         emit ISablierLockupBase.RenounceLockupStream(streamIds[1]);
-        vm.expectEmit({ emitter: address(lockup) });
-        emit IERC4906.MetadataUpdate({ _tokenId: streamIds[1] });
 
         // Renounce the streams.
         lockup.renounceMultiple(streamIds);

tests/integration/concrete/lockup-base/renounce-multiple/renounceMultiple.tree

@@ -17,5 +17,5 @@ RenounceMultiple_Integration_Concrete_Test
                ├── given at least one non cancelable stream
                │  └── it should revert
                └── given all streams cancelable
-                  ├── it should emit {MetadataUpdate} and {RenounceLockupStream} events
+                  ├── it should emit {RenounceLockupStream} events
                   └── it should make streams non cancelable

tests/integration/concrete/lockup-base/renounce/renounce.t.sol

@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: UNLICENSED
 pragma solidity >=0.8.22 <0.9.0;
 
-import { IERC4906 } from "@openzeppelin/contracts/interfaces/IERC4906.sol";
-
 import { ISablierLockupBase } from "src/interfaces/ISablierLockupBase.sol";
 import { Errors } from "src/libraries/Errors.sol";
 
@@ -66,11 +64,9 @@ abstract contract Renounce_Integration_Concrete_Test is Integration_Test {
         givenWarmStreamRenounce
         whenCallerSender
     {
-        // It should emit {MetadataUpdate} and {RenounceLockupStream} events.
+        // It should emit {RenounceLockupStream} event.
         vm.expectEmit({ emitter: address(lockup) });
         emit ISablierLockupBase.RenounceLockupStream(streamId);
-        vm.expectEmit({ emitter: address(lockup) });
-        emit IERC4906.MetadataUpdate({ _tokenId: streamId });
 
         // Renounce the stream.
         lockup.renounce(streamId);

tests/integration/concrete/lockup-base/renounce/renounce.tree

@@ -19,5 +19,5 @@ Renounce_Integration_Concrete_Test
             ├── given non cancelable stream
             │  └── it should revert
             └── given cancelable stream
-               ├── it should emit {MetadataUpdate} and {RenounceLockupStream} events
+               ├── it should emit {RenounceLockupStream} event
                └── it should make stream non cancelable