Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tokenURI function and remove backwards compatility #1112

Closed
andreivladbrg opened this issue Dec 11, 2024 · 2 comments
Closed

Fix tokenURI function and remove backwards compatility #1112

andreivladbrg opened this issue Dec 11, 2024 · 2 comments
Assignees
@smol-ninja
Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

Based on this comment we need to need to fix some strings in the tokenURI function, and based on this discussion we will remove backwards compatibility.
@andreivladbrg andreivladbrg added priority: 0 Do this first before everything else. This is critical and nothing works without this. type: refactor Change that neither fixes a bug nor adds a feature. effort: low Easy or tiny task that takes less than a day. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Dec 11, 2024
@smol-ninja smol-ninja mentioned this issue Dec 11, 2024
Merged
@smol-ninja smol-ninja moved this to 🕵🏻‍♂️ In Review in Lockup 2.0.0 Dec 11, 2024
@PaulRBerg
Copy link
Member

Also let's please say just stream instead of payment stream (to avoid any confusion with the UI).

@smol-ninja
Copy link
Member

Yes @PaulRBerg. Thats what I have done in #1113. You can have a look at the previews in the PR description.

@github-project-automation github-project-automation bot moved this from 🕵🏻‍♂️ In Review to ✅ Done in Lockup 2.0.0 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
No open projects
Lockup 2.0.0
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @andreivladbrg