Fix CREATE2 salt interpolation in multi-chain deployment script

[PaulRBerg]

Here:

v2-core/shell/deploy-multi-chain.sh

Line 178 in 79aa953

\'ChainID $chain_id, Version 1.1.1\' \

I've tried all of the following approaches. None worked:

Approach	Result in Terminal
Surround with \"	'"ChainID' 43114, Version '1.1.1"'
Surround with \'	'\'\''ChainID' 43114, Version '1.1.1\'\'''
Surround with '	''\''ChainID' 43114, Version '1.1.1'\'''
Surround with '	Broken script

What should be generated is this:

"ChainID 43114, Version 1.1.1"

Or this:

'ChainID 43114, Version 1.1.1'

Note: this is best debugged by adding the -x flag here:

$ set -euxo pipefail

[smol-ninja]

Interestingly, it works for v2-periphery. When I was polishing these scripts, even I couldn't manage to make it work for v2-core while it works totally fine for v2-periphery. Although everything looks same including the foundry version (may be I am missing something). Did you try to run the script for v2-periphery with --deterministic flag?

[PaulRBerg]

Interesting. I haven't run the script in V2 Periphery just yet.

[smol-ninja]

There was an issue with our deployment script. See PR: #753.

Bash is very smart to interpret string as executable command. Expanding string using multi line comments doesn't work as intended sometimes. Source https://google.github.io/styleguide/shellguide.html#arrays.

For future, we should adhere to the best practices from Google styleguide.

[smol-ninja]

Update on v2-periphery

It was not even working in v2-periphery correctly. The create2Salt was interpreted as ''''ChainID' 11155111, Version '1.1.0''''. Fixed in sablier-labs/v2-periphery#240.

[PaulRBerg]

Nice finding with the Google styleguide!