refactor: automate libraries linkage and remove precompiles #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
@andreivladbrg this PR is now ready for your review. I also added the changelog. |
smol-ninja
changed the title
andreivladbrg
approved these changes
Jan 24, 2025
|
gj, with the |
andreivladbrg
added a commit
that referenced
this pull request
Jan 27, 2025
* build: replace placeholder with deployed libraries * update deploy optimised code * refactor: remove precompiles * docs: add explanatory comment in deployOptimizedLockup * test: generate placeholders from library name --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on docs for custom deployment docs, I found that its very complicated to make custom deployment if
foundry.tomlcontains hard coded libraries' addresses. So I investigated and found a solution to remove them from thefoundry.tomland automatically replace placeholders with deployed addresses of libraries.This now looks neat to me, but may have an issue that I could not think of, so feedbacks are welcome.
Also, lets review and merge it before merging release PR.
Closes #1160.