Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for certain chords #2

Closed
wants to merge 6 commits into from

Conversation

Quantalabs
Copy link

Should solve most of #1. It still fails for maj13/9, m6/9, and 13/9 chords. I'm not quite sure what a 13/9 chord should be.

I'm going to continue working on a couple things, however, on my fixes branch:

  • Some chord parsing errors from Alternate Parsing Strategies teoria#132
  • Fix 6/9 chord parsing
    • Doesn't work for any 6/9 chord prefixed with a chord type (eg. Maj6/9, m6/9).
  • Default to a Major 7th instead of minor 7th for chord parsing.

@saebekassebil
Copy link
Owner

Hello @Quantalabs - Thank you for interest in Teoria! As discussed in #132 I don't agree with this way of parsing chords by default. Could you provide some example of what you are trying to achieve?

If you have some good examples and a thorough method description I would love to pull this into the main library behind a different parsing algorithm. But please don't use too much of your time trying to "fix" the parsing - as I believe it's already working as it should.

@Quantalabs
Copy link
Author

I agree with your perspective- I've outlined a potential solution: saebekassebil/teoria#132 (comment), and I'll close this for now since it's not going to be used.

@Quantalabs Quantalabs closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants