Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETH Saver app #405

Closed
8 tasks done
sterlu opened this issue Oct 22, 2024 · 5 comments
Closed
8 tasks done

Add ETH Saver app #405

sterlu opened this issue Oct 22, 2024 · 5 comments
Labels
Won't list The app won't be listed.

Comments

@sterlu
Copy link

sterlu commented Oct 22, 2024

Entry type

  • New addition

App info

URL: https://ethsaver.com/

Manifest.json URL: https://ethsaver.com/manifest.json

Name: ETH Saver by DeFi Saver

Description: Boost yield on your staked ETH through the use of different DeFi lending protocols

Icon (PNG, 180x180):
eth-saver-180x180

It's minified via https://tinypng.com: yes

Homepage: https://ethsaver.com
Twitter: https://x.com/defisaver
GitHub: https://github.com/defisaver/
Discord: https://discord.com/invite/XGDJHhZ

App supports batching multiple transactions via Safe: yes/no

Supported networks

- Mainnet

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://github.com/defisaver/defisaver-v3-contracts/tree/main/audits

Code for review

https://github.com/defisaver/defisaver-v3-contracts/
(FE code not open)

Team information

Company: DeFi Saver

Official website: https://defisaver.com/

Point of contact: @sterlu

Email/Telegram: Safe <> DeFi Saver Telegram group exists

@kirkkonen
Copy link

This submission is reviewed and approved by the Product team.

@PooyaRaki
Copy link
Contributor

@sterlu
Thank you for your submission! The app will soon be reviewed by the tech team as the next step.

@PooyaRaki
Copy link
Contributor

@sterlu Could you please grant me access to the app repository so I can continue reviewing it?

@sterlu
Copy link
Author

sterlu commented Dec 31, 2024

Hey @PooyaRaki , the repo isn't open source. This wasn't an issue when DeFi Saver was originally submitted so I was hoping it wouldn't be an issue for the spinoff project as well. Please don't hesitate to reach out via Telegram to discuss if needed.

Happy holidays!

@PooyaRaki
Copy link
Contributor

@sterlu Unfortunately, I can’t approve the submission at this time without reviewing it first. However, we’ll get back to you soon. I’ll close the issue for now and will reopen it with an update as soon as possible.

@PooyaRaki PooyaRaki added the Won't list The app won't be listed. label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Won't list The app won't be listed.
Projects
None yet
Development

No branches or pull requests

3 participants