Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add App] Sky.money #412

Closed
8 tasks done
zdumitru opened this issue Nov 7, 2024 · 10 comments
Closed
8 tasks done

[Add App] Sky.money #412

zdumitru opened this issue Nov 7, 2024 · 10 comments

Comments

@zdumitru
Copy link

zdumitru commented Nov 7, 2024

Entry type

  • New addition

App info

URL: https://app.sky.money/

Manifest.json URL: https://app.sky.money/manifest.json

Name: sky.money

Description: Rewards, savings, upgrade, and trade

Icon (PNG, 180x180):
sky_logo

It's minified via https://tinypng.com: yes

Homepage: https://sky.money/
Twitter: https://x.com/SkyEcosystem
GitHub: https://github.com/skybase-int
Discord: https://discord.gg/skyecosystem

App supports batching multiple transactions via Safe: no

Supported networks

- Mainnet

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://www.chainsecurity.com/smart-contract-audit-reports?client=MakerDao

Code for review

https://github.com/skybase-int/webapp

Team information

Company: TechOps Services

Official website: https://techops.services/

Point of contact: Dumitru

Email/Telegram: contact[at]techops.services

@kirkkonen
Copy link

This app was reviewed and approved by the product team.

@zdumitru
Copy link
Author

zdumitru commented Dec 3, 2024

This app was reviewed and approved by the product team.

Hi @kirkkonen ,
Thanks for approving the app. Can you please share when the app is going to be live? Currently it's not visible in the gnosis safe app list. Thank you!

@PooyaRaki
Copy link

This app was reviewed and approved by the product team.

Hi @kirkkonen , Thanks for approving the app. Can you please share when the app is going to be live? Currently it's not visible in the gnosis safe app list. Thank you!

Hi @zdumitru
Thank you for your submission! The tech team will first review the code and the audit results, followed by the QA team’s review. Once all reviews are complete, we will proceed to list the app.

@iamacook
Copy link
Member

@zdumitru, I’ve reviewed the shared repository, and everything looks good so far. However, I’m unable to find the transaction code. If I understand correctly, it’s handled within the @jetstreamgg/widgets package? Could you grant me access to its code so we can continue the review?

@zdumitru
Copy link
Author

zdumitru commented Dec 10, 2024

@zdumitru, I’ve reviewed the shared repository, and everything looks good so far. However, I’m unable to find the transaction code. If I understand correctly, it’s handled within the @jetstreamgg/widgets package? Could you grant me access to its code so we can continue the review?

Read access given. That repo will be open sourced some time soon.

@iamacook
Copy link
Member

Despite the lack of test coverage, I did not encounter any critical issues with the submission. I’m happy to pass it on to QA for further review. cc @francovenica

@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Dec 10, 2024
@liliya-soroka liliya-soroka moved this from New issues to Ready for QA in Safe{Wallet} Dec 10, 2024
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Dec 18, 2024
@francovenica
Copy link

francovenica commented Dec 20, 2024

1 -Minor issue. The "Copy address" button doesn't work. Clicking on it won't save the address in my clipboard
image

2 - Major issue:
I tried a trade transaction, USDC for DAI, and I was able to sign and execute the approval, but the app "Doesn't notice" that that tx was successfully executed so I'm stuck waiting for the other tx (The trade itself) to show up
image

I had this same issue trying an upgrade from DAI to USDS; Tx executed fine, but the app gets stuck waiting for the upgrade to finish

3 - Major issue:
Having the approved I refreshed the app so I can try the trade of USDC for DAI. I signed the message successfully, but the trade still fails.
image

@francovenica francovenica moved this from QA in progress to Ready for QA in Safe{Wallet} Dec 20, 2024
@liliya-soroka liliya-soroka moved this from Ready for QA to Todo in Safe{Wallet} Dec 27, 2024
@PooyaRaki
Copy link

@zdumitru We are awaiting your response to proceed with the process.

@zdumitru
Copy link
Author

@zdumitru We are awaiting your response to proceed with the process.

Thanks. We'll address the issue and fix is shortly. Will come back to you when done.

@PooyaRaki
Copy link

@zdumitru Thanks for the update, I’m closing this issue for now.
Feel free to reopen it with an update whenever the fix is ready.

@github-project-automation github-project-automation bot moved this from Todo to Done in Safe{Wallet} Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants