Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Niural App #429

Open
8 tasks done
sarinniural opened this issue Jan 8, 2025 · 12 comments
Open
8 tasks done

Add Niural App #429

sarinniural opened this issue Jan 8, 2025 · 12 comments
Assignees
Labels
Ready for Q.A The submission is ready for Q.A. review.

Comments

@sarinniural
Copy link

sarinniural commented Jan 8, 2025

Entry type

  • New addition

App info

URL: https://app.niural.xyz

Manifest.json URL: https://app.niural.xyz/manifest.json

Name: Niural App

Description: All-in-one HR, Global Payroll & PEO, powered by AI

Icon (PNG, 180x180):

Mark (1)

It's minified via https://tinypng.com: no

Homepage: https://niural.com
Twitter: N/A
GitHub: https://github.com/Niural
Discord: N/A

App supports batching multiple transactions via Safe: no

Supported networks

- Mainnet
- Sepolia
- Polygon
- Optimisim
- Arbritrum
- Avalanche
- Binance

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://audits.hacken.io/niural-global-payments/

Code for review

https://github.com/sarinniural/niural-fe-app

Team information

Company: Niural

Official website: https://niural.com

Point of contact: Sarin Regmi

Email/Telegram: [email protected]

@kirkkonen
Copy link

This submission is approved by the product team.

Access to the frontend repo should've been provided to @PooyaRaki

Note: this will be a fork with frontend code only.

@PooyaRaki
Copy link
Contributor

@sarinniural Thanks for your submission. I've reviewed the app and I'm happy to pass it to Q.A @liliya-soroka
I have one question: Since I didn’t see any pull requests (PRs) on your repository, could you clarify if you use a different process for code review?

@sarinniural
Copy link
Author

@PooyaRaki thank you and like @kirkkonen mentioned in the note, this is a fork of the FE only code, as I cannot share the entire mono repo with you.

I will provide access to @liliya-soroka

@PooyaRaki
Copy link
Contributor

PooyaRaki commented Jan 10, 2025

@sarinniural Could you also add me to your contract repo? The result of the audit is ok but I need to check the actual code as well.

@sarinniural
Copy link
Author

Our contract is basic, you can see it here.
We facilitate payments through our app using the standard function calls.

https://etherscan.io/address/0xae85094070faa7f27fcbd7dc9ff5abb6fc1c9e05#code

@PooyaRaki
Copy link
Contributor

@sarinniural Thank you for your prompt response. Although I don’t have access to the actual contract code, given that the audit results are satisfactory, I am inclined to provide a positive technical review.

@sarinniural
Copy link
Author

@PooyaRaki You can see the actual contract code in the etherscan link I provided above.

@PooyaRaki
Copy link
Contributor

@sarinniural By the actual contract code I am referring specifically to the code within the repository itself.
There are other elements in the repository that require checking but, as the audit results are positive and the FE app also looks good I'm happy to give a green light. As a result, the app has been forwarded to Q.A. for further review.

@PooyaRaki PooyaRaki added the Ready for Q.A The submission is ready for Q.A. review. label Jan 10, 2025
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Jan 13, 2025
@liliya-soroka liliya-soroka moved this from New issues to Ready for QA in Safe{Wallet} Jan 13, 2025
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Jan 13, 2025
@francovenica francovenica moved this from QA in progress to Ready for QA in Safe{Wallet} Jan 15, 2025
@PooyaRaki PooyaRaki self-assigned this Jan 20, 2025
@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Safe{Wallet} Jan 20, 2025
@liliya-soroka liliya-soroka added In Q.A The app is currently undergoing Q.A. review. and removed Ready for Q.A The submission is ready for Q.A. review. labels Jan 20, 2025
@liliya-soroka
Copy link
Member

@sarinniural , how can I get access to the app ?

@liliya-soroka liliya-soroka added the Waiting for Owner The submission is awaiting a response from the owner. label Jan 20, 2025
@PooyaRaki PooyaRaki self-assigned this Jan 20, 2025
@liliya-soroka liliya-soroka removed the In Q.A The app is currently undergoing Q.A. review. label Jan 20, 2025
@sarinniural
Copy link
Author

@sarinniural , how can I get access to the app ?

I have provided access to the team for the FE code, if you are looking for the deployed app, it is here https://app.niural.xyz/

@liliya-soroka
Copy link
Member

  1. @sarinniural , could you please give me a test user I can use during the integration testing with Safe?
    To verify integration, I need to check the following cases :
  • the app is connected to the correct safe on the correct network
  • sign and execute at least one tx from your app inside the connected safe
    It seems that without an test account in your system, I can not verify the cases above, so I can not confirm that integration with the safe is done as expected.
    I have tried to create an organization, but I don't see how the tx can be made without KYB process.
  1. Please ,check "Connect" on the attachment below
Image Image

@sarinniural
Copy link
Author

sarinniural commented Jan 21, 2025

@liliya-soroka how were you able to log in, did you visit app.niural.xyz through custom apps, and did you already create a user? I need to enable crypto payments for your user.

The connect button in this screenshot does not apply to payments.

I have created an invoice of $1 in your account. Please sign in, and go to Payments Tab at the top menu, there is $1 invoice, please select it, click Pay invoice, it will take you to the payment methods, choose payment via wallet, it should have automatically selected your safe wallet, click continue and make the payment using USDC, or USDT

@PooyaRaki PooyaRaki added Ready for Q.A The submission is ready for Q.A. review. and removed Waiting for Owner The submission is awaiting a response from the owner. labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Q.A The submission is ready for Q.A. review.
Projects
None yet
Development

No branches or pull requests

4 participants