Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Extract communicator logic from the web #380

Open
1 of 5 tasks
dasanra opened this issue Aug 11, 2022 · 0 comments
Open
1 of 5 tasks

[Epic] Extract communicator logic from the web #380

dasanra opened this issue Aug 11, 2022 · 0 comments

Comments

@dasanra
Copy link
Collaborator

dasanra commented Aug 11, 2022

Overview

We will extract the communicator logic to a separate package so it's easier to implement Safe Apps integration in other interfaces, so its code can be reused. Once we extract it to a separate library we will publish as a package that the web interface will use.

Roadmap Epic:
https://www.notion.so/gnosis-safe/Extract-Communicator-Logic-6d1d7d75c7584c78a084eaa2c242b331

Notes about refactoring
https://www.notion.so/gnosis-safe/AppFrame-refactoring-aec86f7ce0fd49b18f9a621e7f22d5ff

Requirements

  • Separate communicator logic to an isolated component in the web interface
  • Move this code to a separated repository
  • Publish an npm package that can be used later
  • Separate event subscription logic on the web side so there are less dependencies in the hook
  • Review if is possible to decouple the AppComunicator from the iFrame. Currently we need to pass the iFrame to the AppComunicator instance. Maybe it shouldn't be necesary to do it like this

Links

@dasanra dasanra transferred this issue from 5afe/safe-react Oct 19, 2022
@dasanra dasanra removed the Safe Apps label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant