Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot execute SignMessageLib.signMessage assembled from tx builder #556

Open
chiefbiiko opened this issue Mar 8, 2024 · 0 comments
Open

Comments

@chiefbiiko
Copy link

Bug description

Environment

  • Browser: Chromium
  • Wallet: MetaMask
  • Chain: Gnosis Chain

Steps to reproduce

  1. Go to the tx builder and assemble a tx with:
    • address 0xd53cd0aB83D845Ac265BE939c57F53AD838012c9
    • function signMessage
    • message 0x68616c6c6f63
  2. Confirm the tx with $threshold signers
  3. Try execute the tx (will fail)

Expected result

Executing a SignMessageLib.signMessage tx built from the tx builder ui should work.

For SignMessageLib.signMessage the tx builder should always use operation delegatecall instead of call. The latter will always fail as the library function is referring to Safe contract storage that is only available when executing the tx via delegatecall.

Obtained result

The tx builder wrongfully sets operation call for SignMessageLib.signMessage invocations and there is no ui input to manually change it to delegatecall.

Screenshots

Shows operation call wrongfully set for SignMessageLib.signMessage:

safestucksignmsgviaui

Moved from safe-global/safe-wallet-web#3406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant