Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a custom safe app with a localhost url that contains a port no longer works. #601

Open
aLANparty opened this issue Aug 25, 2024 · 1 comment

Comments

@aLANparty
Copy link

Hi, I'm not sure where exactly to post this so my apologies if this is not the correct place.

We ran into an issue that started I think today, but possibly as far back as a week. We use a custom gnosis safe app for a few people to manage an nft project and until just recently we have been using the app with a url of http://localhost:3000 which is the default port used by our js framework for local dev mode.

We first noticed today that this now fails with an error in the console about a CSP restriction on frame-src http://*, https://*. Which blocks the app from loading in the iframe.

To get around the issue we found that if we run the app or port 80 instead of 3000 we can add the app with the url http://localhost and continue to use it as we have been without issue. I should note that http://localhost:80 also fails to load.

So my guess is that something has changed related to the frame-src restriction that prevents urls with ports in them from loading.

Everything is working fine for us with the switch to http://localhost, but I wanted to submit this incase this was an unintended change.

Thanks.

@parius
Copy link

parius commented Oct 8, 2024

@aLANparty thanks for reporting and sorry for returning back with a delay.
The issues was known to us, and the fix went live on 28th Aug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants