Improve test descriptions

safe-global · Feb 20, 2025 · 44128e5 · 44128e5
1 parent 4e382a7
commit 44128e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/sdk-starter-kit/src/SafeClient.test.ts b/packages/sdk-starter-kit/src/SafeClient.test.ts
@@ -185,7 +185,7 @@ describe('SafeClient', () => {
   })
 
   describe('confirm', () => {
-    it('should confirm the transaction using the Transaction service when not having enough signatures', async () => {
+    it('should execute the transaction after reaching the threshold with the confirmation', async () => {
       const TRANSACTION_RESPONSE = {
         confirmations: [{ signature: '0x1' }],
         confirmationsRequired: 2
@@ -218,7 +218,7 @@ describe('SafeClient', () => {
       })
     })
 
-    it('should execute the transaction when having enough signatures', async () => {
+    it('should execute the transaction without confirmation if already having enough signatures', async () => {
       const TRANSACTION_RESPONSE = {
         confirmations: [{ signature: '0x1' }, { signature: '0x2' }],
         confirmationsRequired: 2
@@ -242,7 +242,7 @@ describe('SafeClient', () => {
       })
     })
 
-    it('should indicate more signatures are required when threshold is not matched', async () => {
+    it('should return that more signatures are required when threshold is not reached after confirmation', async () => {
       const TRANSACTION_RESPONSE = {
         confirmations: [{ signature: '0x1' }],
         confirmationsRequired: 2

diff --git a/packages/sdk-starter-kit/src/extensions/safe-operations/SafeOperationClient.test.ts b/packages/sdk-starter-kit/src/extensions/safe-operations/SafeOperationClient.test.ts
@@ -152,7 +152,7 @@ describe('SafeOperationClient', () => {
   })
 
   describe('confirmSafeOperation', () => {
-    it('should send the Safe operation to the bundler without confirmation when threshold is already reached', async () => {
+    it('should send the User operation to the bundler without confirmation when threshold is already reached', async () => {
       protocolKit.getThreshold = jest.fn().mockResolvedValue(2)
 
       const safeOperationResult = await safeOperationClient.confirmSafeOperation({
@@ -176,7 +176,7 @@ describe('SafeOperationClient', () => {
       })
     })
 
-    it('should indicate more signatures are required when threshold is not reached', async () => {
+    it('should return more signatures are required when threshold is not reached after confirmation', async () => {
       protocolKit.getThreshold = jest.fn().mockResolvedValue(3)
 
       const safeOperationResult = await safeOperationClient.confirmSafeOperation({
@@ -195,7 +195,7 @@ describe('SafeOperationClient', () => {
       })
     })
 
-    it('should confirm and execute when the confirmation ends with the threshold reached', async () => {
+    it('should send the User operation to the bundler alter reaching the threshold with the confirmation', async () => {
       const CONFIRMED_SAFE_OPERATION_RESPONSE = {
         ...SAFE_OPERATION_RESPONSE,
         confirmations: [