Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeMultisigTransactionResponse type is incorrect #1008

Open
mmv08 opened this issue Oct 14, 2024 · 0 comments
Open

SafeMultisigTransactionResponse type is incorrect #1008

mmv08 opened this issue Oct 14, 2024 · 0 comments

Comments

@mmv08
Copy link
Member

mmv08 commented Oct 14, 2024

Description

The type SafeMultisigTransactionResponse is incorrect:

export type SafeMultisigTransactionResponse = {

For example, the property transactionHash is marked as required, but the transaction may not have a transaction hash until it is executed. The same goes for the execution date.

Proof:
image

Environment

  • Safe Core SDK versions:
    • types-kit: 5.1.0

Expected result

The types are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@mmv08 and others