Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-starter-kit): Enable confirmed txs and safe operations execution #1144

Merged

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Feb 20, 2025

What it solves

Resolves #1141

How this PR fixes it

We are now validating in the confirm methods (confirmTransaction and confirmSafeOperation) whether the transaction or User operation has enough signatures. In this case we execute or send it the bundler without calling the confirmation method from the api-kit

@coveralls
Copy link

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13522924868

Details

  • 18 of 20 (90.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 78.287%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk-starter-kit/src/SafeClient.ts 9 10 90.0%
packages/sdk-starter-kit/src/extensions/safe-operations/SafeOperationClient.ts 9 10 90.0%
Totals Coverage Status
Change from base Build 13434132612: -0.3%
Covered Lines: 905
Relevant Lines: 1081

💛 - Coveralls

@yagopv yagopv marked this pull request as ready for review February 20, 2025 16:50
@yagopv yagopv requested review from dasanra and DaniSomoza and removed request for dasanra February 20, 2025 16:50
@dasanra dasanra merged commit 4903c25 into development Feb 25, 2025
21 of 22 checks passed
@dasanra dasanra deleted the feat/enable-confirmed-txs-and-safe-operations-execution branch February 25, 2025 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants