Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AbiType to type MultiSend contract #654

Closed
dasanra opened this issue Jan 8, 2024 · 0 comments · Fixed by #663
Closed

Use AbiType to type MultiSend contract #654

dasanra opened this issue Jan 8, 2024 · 0 comments · Fixed by #663
Assignees
@yagopv

Comments

@dasanra
Copy link
Collaborator

dasanra commented Jan 8, 2024

Context / issue

The current typing library is deprecated and this prevent us to update to Web3.js v4 or adding Viem as an adapter in the protocol-kit. Also it's way more complex than current solutions adding more complexity to the SDK maintenance.

#577

Proposed solution

Migrate MultiSend and MultisendCallOnly types for web3.js and ethers adapter based on the previous PR #604 .
@yagopv yagopv self-assigned this Jan 9, 2024
@yagopv yagopv mentioned this issue Jan 12, 2024
Merged
@yagopv yagopv linked a pull request Jan 16, 2024 that will close this issue
feat(protocol-kit): Add AbiType for Multisend #663
Merged
@yagopv yagopv closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(protocol-kit): Add AbiType for Multisend safe-global/safe-core-sdk
2 participants
@yagopv @dasanra