Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a disposable private key in the 4337 tests #938

Open
leonardotc opened this issue Aug 8, 2024 · 0 comments
Open

Use a disposable private key in the 4337 tests #938

leonardotc opened this issue Aug 8, 2024 · 0 comments

Comments

@leonardotc
Copy link
Contributor

Context / issue

Currently, private keys for 4337 tests are used as CI secrets, most likely, to prevent random people to alter the state of chain in a way that break our tests hindering our operations. That introduces two issues:

  • We either have toi share a (couple) of private key secrets internally everytime some change to the implemtantion breaks the tests or we recreate the same conditions for the associated eoas/multisig which takes some effort and suffering.
  • externals will never, in their lives, be able to execute (and get runtime information from) those tests.

Proposed solution

  • Add fixtures for private keys
  • Mock the transport to avoid any consequences that could affect the result of those tests

Expected outcome

  • No data should be read from process.env in the tests of the 4337 module.
  • No secrets data should be contained on .github/workflows/sdk-test.yml
  • The tests for the 4337 module should pass locally and on the CI.
@leonardotc leonardotc self-assigned this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant