Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relay-kit): Add UserOperation custom nonce support #1126

Merged
merged 69 commits into from
Feb 10, 2025
Merged

feat(relay-kit): Add UserOperation custom nonce support #1126

merged 69 commits into from
Feb 10, 2025

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Feb 7, 2025 •
edited
Loading

What it solves

Adding support for custom nonce is a common requested feature

How this PR fixes it

By allowing to specify a custom nonce in the createTransaction method

We are exporting a encodeNonce utility to create custom nonces

Added a new playground to test the parallel execution of user operations as described here

Testing Safe: https://app.safe.global/transactions/history?safe=sep:0x66d58aFE9eDB356f08C5daFa9a54eBaC33971073

yagopv added 30 commits January 10, 2025 16:01
@yagopv
Add a specific userOperations module
22ceffc
@yagopv
eth_estimateUserOperationGas v0.7 support
5ab7193
@yagopv
Fix initCode
ee61a99
@yagopv
Change SafeOp structure
7a1a767
@yagopv
Working version for sponsored transactions
36c2da9
@yagopv
Update playgrounds
feda7e8
@yagopv
Fix SigningMethod evaluated incorrectly
77c9973
@yagopv
Fix paymaster 0x0000...
8eff392
@yagopv
Add more RPC calls
dbe373d
@yagopv
Update to work with new Pimlico paymasters
9fcea54
@yagopv
Improvements
5eff169
@yagopv
Update playgrounds
19b63c7
@yagopv
Update comments in playgrounds
71048b4
@yagopv
Improve SafeOperation
a27f78d
@yagopv
Remove calculateSafeUserOperationHash
d94bbe8
@yagopv
Improve dummySignatures retrieval
0cd4cfa
@yagopv
Improve version management for SafeOperations
ce90770
@yagopv
Merge branch 'development' of https://github.com/safe-global/safe-cor…
3c75c5d 
…e-sdk into feat/entrypoint-v7

# Conflicts:
#	packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts
@yagopv
Fix other kits
958316c
@yagopv
Refactor rpc schemas
503a7cc
@yagopv
Some improvements
c60dd14
@yagopv
Improve playgrounds
38c85fb
@yagopv
Fix SafeOperationV06
e1fa4b4
@yagopv
Update playgrounds
0a4ba15
@yagopv
uncomment
3c524f3
@yagopv
Merge branch 'development' of https://github.com/safe-global/safe-cor…
e245d03 
…e-sdk into feat/entrypoint-v7

# Conflicts:
#	yarn.lock
@yagopv
Improve imports
e6559c1
@yagopv
Fix tests
a204a8a
@yagopv
Downgrade viem version breaking tests
800d2a0
@yagopv
Fix tests
d0e1147
yagopv and others added 17 commits February 4, 2025 15:07
@yagopv
Add test
e0ace1d
@yagopv
Fix checksum shared signer
bfe5591
@yagopv
Update api-kit-interoperability
e145ac4
@yagopv @dasanra
Update playground/utils.ts
6dc64ad 
Co-authored-by: Daniel <[email protected]>
@yagopv @dasanra
Update packages/protocol-kit/src/utils/signatures/utils.ts
3182c56 
Co-authored-by: Daniel <[email protected]>
@yagopv @dasanra
Update packages/relay-kit/src/packs/safe-4337/Safe4337Pack.test.ts
36f2f16 
Co-authored-by: Daniel <[email protected]>
@yagopv
Fix using viem sepolia chain in tests
6130264
@yagopv
Merge branch 'feat/entrypoint-v7' of https://github.com/safe-global/s…
c3a3e20 
…afe-core-sdk into feat/entrypoint-v7

# Conflicts:
#	playground/utils.ts
@yagopv
Remove SafeOperation Interface
e49b3e8
@yagopv
Renamed SafeOperationBase -> SafeOperation
609aa1b
@yagopv
Merge branch 'development' into feat/entrypoint-v7
d775fb4
@yagopv
Add test
028c582
@yagopv
Add paralell useroperation support
3ffab9f
@yagopv
restore SafeOperation interface and rename the class to BaseSafeOpera…
480f84a 
…tion
@yagopv
Merge branch 'feat/entrypoint-v7' into feat/user-operation-custom-nonce
e9b2851 
# Conflicts:
#	packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts
@yagopv
Fix
13fec41
@yagopv
Remove redundant comment
d5e088f
@yagopv yagopv marked this pull request as ready for review February 10, 2025 09:37
@yagopv yagopv requested review from dasanra and DaniSomoza February 10, 2025 09:37
@dasanra dasanra linked an issue Feb 10, 2025 that may be closed by this pull request
[relay-kit] Specify custom nonce and checksum addresses #1082
Closed
Base automatically changed from feat/entrypoint-v7 to development February 10, 2025 10:13
@yagopv
Merge branch 'development' of https://github.com/safe-global/safe-cor…
3e1ee43 
…e-sdk into feat/user-operation-custom-nonce

# Conflicts:
#	packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts
#	packages/relay-kit/src/packs/safe-4337/utils/index.ts
#	packages/relay-kit/src/packs/safe-4337/utils/userOperations.ts
#	playground/config/run.ts
@coveralls
Copy link

coveralls commented Feb 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13239953107

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 78.049%
Totals Coverage Status
Change from base Build 13238431088: 0.1%
Covered Lines: 893
Relevant Lines: 1073
💛 - Coveralls

@yagopv yagopv merged commit 2dc8f97 into development Feb 10, 2025
22 checks passed
@yagopv yagopv deleted the feat/user-operation-custom-nonce branch February 10, 2025 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[relay-kit] Specify custom nonce and checksum addresses
3 participants
@yagopv @coveralls @dasanra