Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add value to TransactionOptions #656

Closed
wants to merge 1 commit into from

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Jan 9, 2024

What it solves

Resolves #638

How this PR fixes it

This PR adds the value to the TransactionOptions object used to execute transactions. The value will be used in the internal transaction produced by ethers or web3 so it's possible to send funds before executing the transaction

@yagopv yagopv changed the title feat: Add value to the TransactionOptions feat: Add value to TransactionOptions Jan 9, 2024
@yagopv yagopv changed the base branch from main to development January 9, 2024 15:14
@yagopv yagopv requested review from DaniSomoza and dasanra January 9, 2024 15:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7462985041

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.502%

Totals Coverage Status
Change from base Build 7447494616: 0.0%
Covered Lines: 481
Relevant Lines: 597

💛 - Coveralls

@yagopv yagopv closed this Jan 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
@yagopv yagopv deleted the feat/send-signer-tx-value branch January 23, 2024 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransactionOptions type missing optional value parameter, necessary for when passing value from EOA to Safe
2 participants