Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data decoder endpoint #61

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add data decoder endpoint #61

merged 3 commits into from
Jan 16, 2025

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Jan 10, 2025 •
edited
Loading

@coveralls
Copy link

coveralls commented Jan 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12809147111

Details

  • 32 of 40 (80.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 92.283%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/routers/models.py 24 27 88.89%
app/routers/data_decoder.py 6 11 54.55%
Totals Coverage Status
Change from base Build 12808881394: -0.6%
Covered Lines: 873
Relevant Lines: 946
💛 - Coveralls

@falvaradorodriguez falvaradorodriguez force-pushed the add-data-decoder-endpoint branch from 1e3f0d2 to 28cb5a4 Compare January 13, 2025 12:37
@falvaradorodriguez falvaradorodriguez force-pushed the add-data-decoder-endpoint branch from 28cb5a4 to 1eaed71 Compare January 13, 2025 12:55
@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review January 13, 2025 13:04
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner January 13, 2025 13:04
moisses89
moisses89 requested changes Jan 16, 2025
View reviewed changes
app/routers/models.py Show resolved Hide resolved
app/services/data_decoder.py Show resolved Hide resolved
@falvaradorodriguez falvaradorodriguez force-pushed the add-data-decoder-endpoint branch from 28ab921 to d0d93a9 Compare January 16, 2025 12:24
@moisses89 moisses89 mentioned this pull request Jan 16, 2025
Open
@moisses89 moisses89 self-requested a review January 16, 2025 12:33
@falvaradorodriguez falvaradorodriguez force-pushed the add-data-decoder-endpoint branch from d0d93a9 to f033ffb Compare January 16, 2025 12:44
@falvaradorodriguez falvaradorodriguez merged commit 4e61524 into main Jan 16, 2025
5 checks passed
@falvaradorodriguez falvaradorodriguez deleted the add-data-decoder-endpoint branch January 16, 2025 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data decoder endpoint
3 participants
@falvaradorodriguez @coveralls @moisses89