Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Zodiac Module - Inexistent API Endpoint #910

Closed
0xferit opened this issue Feb 13, 2025 · 2 comments
Closed

[BUG] Zodiac Module - Inexistent API Endpoint #910

0xferit opened this issue Feb 13, 2025 · 2 comments

Comments

@0xferit
Copy link

0xferit commented Feb 13, 2025

Navigate to the Zodiac app on Optimism and see the console (index.ts:41 Code 901: Error processing Safe Apps SDK request). The same issue also appears on the Ethereum Sepolia Testnet and likely in many more.

It tries to GET https://safe-transaction-optimism.safe.global/api/v1/safes/{address}/transactions?nonce__gte={nonce} which does not exist. So, it returns HTTP 404.

Example URL it tries and can't GET: https://safe-transaction-optimism.safe.global/api/v1/safes/0x85dA68c9bF4953cd4547D415d6DCB9C3Fd2f79F8/transactions?nonce__gte=2

I checked the API docs; there is no such endpoint listed: https://docs.safe.global/core-api/transaction-service-reference/mainnet#Transactions

This breaks the functionality of the Zodiac app. For example, I cannot add any new roles to the Roles Modifier.

@0xferit 0xferit changed the title Optimism - Zodiac Module - Wrong API Endpoint Zodiac Module - Inexistent API Endpoint Feb 13, 2025
@0xferit 0xferit changed the title Zodiac Module - Inexistent API Endpoint [BUG] Zodiac Module - Inexistent API Endpoint Feb 13, 2025
@mmv08
Copy link
Member

mmv08 commented Feb 13, 2025

I think you might be looking for the /multisig-transactions endpoint, which works:

https://safe-transaction-optimism.safe.global/api/v1/safes/0x85dA68c9bF4953cd4547D415d6DCB9C3Fd2f79F8/multisig-transactions/?nonce__gte=2

This repository is for smart contracts only. If you have more questions/issues, please open it in the wallet app repository: https://github.com/safe-global/safe-wallet-monorepo

Also, the zodiac app is not maintained by the Safe team, so you should report it to Zodiac.

@mmv08 mmv08 closed this as completed Feb 13, 2025
@0xferit
Copy link
Author

0xferit commented Feb 13, 2025

Thanks for pointing out the correct repository.

But this bug belongs to Gnosis Safe since it's the Gnosis Safe web app that calls the wrong API endpoint. So I'm going to reopen this in the correct repository.

safe-global/safe-wallet-monorepo#4983 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants