Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functionality (and Alert) for Detecting Proxies on Machine #1306

Closed
avoidthehack opened this issue Aug 31, 2023 · 6 comments
Closed

Add Functionality (and Alert) for Detecting Proxies on Machine #1306

avoidthehack opened this issue Aug 31, 2023 · 6 comments
Labels
stale ATTRIBUTE: this issue has not had recent activity suggestion TYPE: idea for new feature or improvements

Comments

@avoidthehack
Copy link

What would you like to add or change?:
I noticed that Proton VPN's App (Windows, specifically) was able to detect when a proxy was running on the system.

When I ran the proxy, Portmaster could see the traffic being forwarded to the proxy (127.0.0.1:8080) so would it be possible to have Portmaster do something similar? If this is possible, could an alert also be added if a proxy is suspected and possible ramifications of this? An Alert could warn "Portmaster detected a running proxy. Not all connections may be secured by Portmaster."

By extension, could this also be done when the machine is connected to a VPN? Perhaps minus the Alert.

@avoidthehack avoidthehack added the suggestion TYPE: idea for new feature or improvements label Aug 31, 2023
@dhaavi
Copy link
Member

dhaavi commented Aug 31, 2023

Okay, if I understand there are two parts to this:

  1. Detect if a proxy or VPN is in use.
  2. Display that fact in the UI and warn the user if this has an impact on the protection of Portmaster.

Which leads me to:

  1. Inspect proxy traffic and correctly apply rules to it. (If the connection is not encrypted, which very likely on localhost.)

And obviously the last step here is:

  1. make the SPN use the proxy to establish a connection and start redirecting traffic through the SPN instead and ignore the proxy.

Very nice ideas. Thank you very much. I will think about this over the weekend and talk with the team about this next week.

@avoidthehack
Copy link
Author

That's precisely it! :)

Copy link

github-actions bot commented Nov 3, 2023

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

@github-actions github-actions bot added the stale ATTRIBUTE: this issue has not had recent activity label Nov 3, 2023
@Raphty
Copy link
Member

Raphty commented Nov 6, 2023

@dhaavi I know this has been a while, but can you pleas give @avoidthehack an update and I believe we have in cooperated that into our internal tools so we can close the issue, but with a comment :D

@github-actions github-actions bot removed the stale ATTRIBUTE: this issue has not had recent activity label Nov 7, 2023
Copy link

github-actions bot commented Jan 9, 2024

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

@github-actions github-actions bot added the stale ATTRIBUTE: this issue has not had recent activity label Jan 9, 2024
Copy link

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

If the issue has not been resolved, you can find more information in our Wiki or continue the conversation on our Discord.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale ATTRIBUTE: this issue has not had recent activity suggestion TYPE: idea for new feature or improvements
Projects
None yet
Development

No branches or pull requests

3 participants