fix(InvoiceDetailView): correct attribute path for accessing customer… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contact details in InvoiceDetailView Fixed an error in get_context_data method within InvoiceDetailView in sage_invoice/views/invoice.py. The method previously attempted to access invoice.customer.contact["Contact Info"].get(...), but the contact attribute was incorrectly specified as contacts. Adjusted the attribute path to correctly access customer email and phone details, ensuring reliable data retrieval. Updated .gitignore to include paths related to invoice uploads for better file management. Bumped the project version in pyproject.toml to reflect these updates. Closes sageteamorg#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… contact details in InvoiceDetailView
Fixed an error in get_context_data method within InvoiceDetailView in sage_invoice/views/invoice.py. The method previously attempted to access invoice.customer.contact["Contact Info"].get(...), but the contact attribute was incorrectly specified as contacts. Adjusted the attribute path to correctly access customer email and phone details, ensuring reliable data retrieval. Updated .gitignore to include paths related to invoice uploads for better file management. Bumped the project version in pyproject.toml to reflect these updates.
Closes #23