feat: add support for landscape transformer power on/off #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #21 and adds support for the low voltage landscape transformer here
I wanted to be sure I could test this all locally, so I started by adding jest for testing (along with ts-jest for transpiling). From there, I added support for the low-voltage transformer as an extension of the smart outlet (because it's really just a multi-zone outlet).
This full PR adds support for all 3 zones to power on/off. I have tested this using my own product at home using the tests that are marked skipped right now, and captured the portions of the HTTP responses needed to add mock tests to protect future changes from breaking this functionality.
Thanks!