diff --git a/app/business/pom.xml b/app/business/pom.xml index f9cbe2f2..9451fb07 100644 --- a/app/business/pom.xml +++ b/app/business/pom.xml @@ -50,7 +50,6 @@ org.sakaiproject.edu-services.gradebook gradebook-service-hibernate - provided org.sakaiproject.edu-services.gradebook @@ -65,8 +64,6 @@ org.sakaiproject.edu-services.scoringservice scoring-service-api - provided - ${sakai.version} @@ -117,7 +114,6 @@ org.springframework spring-test - ${sakai.spring.version} aopalliance diff --git a/app/business/src/java/org/sakaiproject/tool/gradebook/business/impl/GradebookCalculationImpl.java b/app/business/src/java/org/sakaiproject/tool/gradebook/business/impl/GradebookCalculationImpl.java index ac420e7a..a44b4bf1 100644 --- a/app/business/src/java/org/sakaiproject/tool/gradebook/business/impl/GradebookCalculationImpl.java +++ b/app/business/src/java/org/sakaiproject/tool/gradebook/business/impl/GradebookCalculationImpl.java @@ -421,19 +421,14 @@ else if(gradebook.getCategory_type() == GradebookService.CATEGORY_TYPE_ONLY_CATE return totalPointsPossible; } - - @Override - public void applyDropScores(Collection gradeRecords) { - if (gradeRecords != null && gradeRecords.iterator().hasNext()) { - AssignmentGradeRecord firstRecord = gradeRecords.iterator().next(); - super.applyDropScores(gradeRecords, firstRecord.getGradableObject().getGradebook().getCategory_type()); - } - } @Override - public Long createCategory(Long gradebookId, String name, Double weight, Integer dropLowest, Integer dropHighest, - Integer keepHighest, Boolean is_extra_credit) - throws ConflictingCategoryNameException, StaleObjectModificationException { - return super.createCategory(gradebookId, name, weight, dropLowest, dropHighest, keepHighest, is_extra_credit, false); + public Long createCategory(Long gradebookId, String name, Double weight, Integer dropLowest, Integer dropHighest, Integer keepHighest, Boolean is_extra_credit) throws ConflictingCategoryNameException, StaleObjectModificationException { + return super.createCategory(gradebookId, name, weight, dropLowest, dropHighest, keepHighest, is_extra_credit, false, null); } + + @Override + public void applyDropScores(Collection gradeRecords) { + super.applyDropScores(gradeRecords, GradebookService.CATEGORY_TYPE_NO_CATEGORY); + } } diff --git a/app/business/src/java/org/sakaiproject/tool/gradebook/framework/GradebookEntityProducer.java b/app/business/src/java/org/sakaiproject/tool/gradebook/framework/GradebookEntityProducer.java index ce032b95..d0d60da2 100644 --- a/app/business/src/java/org/sakaiproject/tool/gradebook/framework/GradebookEntityProducer.java +++ b/app/business/src/java/org/sakaiproject/tool/gradebook/framework/GradebookEntityProducer.java @@ -133,7 +133,7 @@ public String[] myToolIds() { } @Override - public Map transferCopyEntities(String fromContext, String toContext, List ids, List options) { + public Map transferCopyEntities(String fromContext, String toContext, List ids, List transferOptions) { Gradebook gradebook = (Gradebook) this.gradebookService.getGradebook(fromContext); GradebookInformation gradebookInformation = this.gradebookService.getGradebookInformation(gradebook.getUid()); @@ -144,7 +144,7 @@ public Map transferCopyEntities(String fromContext, String toCon } @Override - public Map transferCopyEntities(String fromContext, String toContext, List ids, List options, boolean cleanup) { + public Map transferCopyEntities(String fromContext, String toContext, List ids, List transferOptions, boolean cleanup) { if (cleanup) { Gradebook gradebook = (Gradebook) this.gradebookService.getGradebook(toContext); @@ -159,7 +159,7 @@ public Map transferCopyEntities(String fromContext, String toCon } // now migrate - return transferCopyEntities(fromContext, toContext, ids, options); + return transferCopyEntities(fromContext, toContext, ids, transferOptions); } @Override diff --git a/app/sakai-tool/src/webapp/WEB-INF/applicationContext.xml b/app/sakai-tool/src/webapp/WEB-INF/applicationContext.xml index 1f3f570f..ea0aa5f1 100644 --- a/app/sakai-tool/src/webapp/WEB-INF/applicationContext.xml +++ b/app/sakai-tool/src/webapp/WEB-INF/applicationContext.xml @@ -23,7 +23,7 @@ diff --git a/app/ui/pom.xml b/app/ui/pom.xml index 85ec62f2..fa0d6053 100644 --- a/app/ui/pom.xml +++ b/app/ui/pom.xml @@ -141,7 +141,6 @@ org.springframework spring-test - ${sakai.spring.version} aopalliance diff --git a/app/ui/src/webapp/WEB-INF/applicationContext.xml b/app/ui/src/webapp/WEB-INF/applicationContext.xml index c4a904e2..32fc66aa 100644 --- a/app/ui/src/webapp/WEB-INF/applicationContext.xml +++ b/app/ui/src/webapp/WEB-INF/applicationContext.xml @@ -8,7 +8,7 @@ + destroy-method="destroy"> diff --git a/pom.xml b/pom.xml index 67f12cec..ffe67287 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,6 @@ org.sakaiproject master 22-SNAPSHOT - ../master/pom.xml Sakai Gradebook Project @@ -21,7 +20,6 @@ - org.sakaiproject sakai-gradebook-app-ui @@ -38,23 +36,16 @@ ${project.version} pom - - org.sakaiproject.edu-services.gradebook gradebook-service-impl ${sakai.version} - org.sakaiproject.edu-services.gradebook - gradebook-service-hibernate - ${sakai.version} - provided - - - org.sakaiproject.edu-services.sections - sections-impl-standalone - ${sakai.version} + org.sakaiproject.edu-services.scoringservice + scoring-service-api + ${sakai.version} + provided