-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/10029 #10558
Open
gandolfslayer
wants to merge
53
commits into
salesagility:hotfix-7.13.x
Choose a base branch
from
gandolfslayer:fix/10029
base: hotfix-7.13.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/10029 #10558
gandolfslayer
wants to merge
53
commits into
salesagility:hotfix-7.13.x
from
gandolfslayer:fix/10029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…appear when duplicating records
Previously, the ElasticSearch Indexing would assume that if there were errors in a batch that all items in the batch had an error. This fix only logs errors when an item actually has an error present.
…ication of assignments does not work
…Quickcreate: selectTabOnError Found that the name of the function selectTabOnError has been declared twice at the theme SuiteP If I change the definition of the function from let to var it does not throws the error on the javascript console.
Count bracket is closed after relational operator it must be typo mistake done years ago before PHP 8.0 count() use to yield a warning but after PHP 8.0 count() will throw TypeError if countable types parameter is not passed, in this case Boolean value was feeding to count so it was throwing TypeError in PHP 8.0+
…um in workflow formulas
…ll user records
…e name exceeds 36 characters.
…rflow Prior to this change, overflow of the dashlet options popup div were set to hidden. Now they are set to auto to allow scrollbars when content overflows.
- Fix failing Email test
… issue The save function is unnecessary and create a duplication of ater_save hooks on duplicate records
…ertain formats
…rval for certain datetime formats Use proper user datetime format to convert datetime string to timestamp in SugarFeed.php
Workflows Calculate Field Actions don't translate dynamicenum fields
…cted on current page Change how UID array is built in assignGroups
…rt to use user-defined decimal separator
Make object instead of calling function statically
Hello @gandolfslayer, thanks for your PR, could you, please:
For more details on how to contribute to our project visit the link below: Thanks in advance! Regards, |
serhiisamko091184
added
the
Status:Requires Updates
Issues & PRs which requires input or update from the author
label
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How To Test This
Types of changes
Final checklist