Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/10029 #10558

Open
wants to merge 53 commits into
base: hotfix-7.13.x
Choose a base branch
from
Open

Conversation

gandolfslayer
Copy link

Description

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

SinergiaCRM and others added 30 commits December 15, 2022 11:34
Previously, the ElasticSearch Indexing would assume that if there were errors in a batch that all items in the batch had an error.  This fix only logs errors when an item actually has an error present.
…Quickcreate: selectTabOnError

Found that the name of the function selectTabOnError has been declared
twice at the theme SuiteP

If I change the definition of the function from let to var it does
not throws the error on the javascript console.
Count bracket is closed after relational operator it must be typo mistake done years ago
before PHP 8.0 count() use to yield a warning but after PHP 8.0 count() will throw TypeError if countable types parameter is not passed, in this case Boolean value was feeding to count so it was throwing TypeError in PHP 8.0+
…rflow

Prior to this change, overflow of the dashlet options popup div were set to hidden.  Now they are set to auto to allow scrollbars when content overflows.
- Fix failing Email test
eojedapilchik and others added 23 commits April 4, 2023 15:47
… issue

The save function is unnecessary and create a duplication of ater_save hooks on duplicate records
…rval for certain datetime formats

Use proper user datetime format to convert datetime string to timestamp in SugarFeed.php
Workflows Calculate Field Actions don't translate dynamicenum fields
…cted on current page

Change how UID array is built in assignGroups
Make object instead of calling function statically
@serhiisamko091184
Copy link
Contributor

Hello @gandolfslayer,

thanks for your PR,

could you, please:

  1. update your branch and re-push your fix;
  2. add more information on the issue you are intended to suggest the fix for;

For more details on how to contribute to our project visit the link below:
https://docs.suitecrm.com/community/contributing-code/bugs/

Thanks in advance!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.