Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10580 - Import float values ​​with correct decimal separator #10581

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

This PR modifies the importSanitize function in the include/SugarFields/Fields/Float/SugarFieldFloat.php file to treat Float fields the same as Decimal fields so that float values ​​are imported with the correct decimal separator.

How To Test This

  1. Set the decimal comma separator (,) in the user profile
  2. Create a Float type field in the Contacts module
  3. Create a record and assign a value to the previous field
  4. Export the Contact and edit the generated file to leave only the last name column (required field) and the Float field column.
  5. Import the file and check that the value of the Float field is the same and that it uses the decimal symbol configured in the logged in user profile

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed Status: Requires Code Review Needs the core team to code review labels Nov 21, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for your contribution!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants