Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salesagility#10574 - Display TinyMCE in PDF templates after adding a wysiwyg field #10583

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

In this PR the TinyMCE plugin configuration in the include/SugarFields/Fields/Wysiwyg/SugarFieldWysiwyg.php file is overridden if the module is AOS_PDF_Templates as it seems that the error occurs because another TinyMCE configuration is already preloaded

How To Test This

  1. Go to Administration -> Studio -> PDF Templates
  2. Create a WYSIWYG field
  3. Edit the Edit View and add the new WYSIWYG field
  4. Go to PDF Templates -> Create PDF Template
  5. Check that the TinyMCE editor for the new wysiwyg type field is displayed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: PDFs Issues & PRs related to all things regarding PDFs Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Nov 21, 2024
@serhiisamko091184
Copy link
Contributor

Hey @SinergiaCRM!

Thanks for your contribution!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: PDFs Issues & PRs related to all things regarding PDFs Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants