fix: disable deprecation warnings #1971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disables deprecation warnings by passing in the
--no-deprecation
flag to nodeforcedotcom/cli#2535
--no-deprecation
:https://nodejs.org/api/cli.html#--no-deprecation
Why not use
--disable-warning= DEP0040
to only disable the punycode deprecation warning?--disable-warning
was added in node v21, we still support node v18 so we can't use that flag yet.Setting it dynamically like in the block above doesn't work because
NODE_OPTIONS
is expected to be set before the node process starts.https://nodejs.org/docs/latest-v22.x/api/cli.html#--disable-warningcode-or-type
https://nodejs.org/api/deprecations.html#dep0040-nodepunycode-module
Acceptance Criteria
How do you know this change is successful? What is the scope of this change? What tests test the criteria (or why no tests)?
The Acceptance Criteria can be copied from the work item if they exist there but it is useful to have on the PR when reviewing the code.
Testing Notes
run commands via
bin/run
on node v18, v22 and v23, see there's no deprecation warnings from punycode usage.What issues does this PR fix or reference?
@W-17013195@