Merge pull request #853 from salesforcecli/devScripts2023-11-05

refactor: devScripts update

package.json

@@ -19,36 +19,16 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^4.0.14",
     "@salesforce/cli-plugins-testkit": "^4.4.12",
-    "@salesforce/dev-config": "^4.1.0",
-    "@salesforce/dev-scripts": "^5.12.2",
+    "@salesforce/dev-scripts": "^6.0.3",
     "@salesforce/plugin-command-reference": "^3.0.42",
-    "@salesforce/prettier-config": "^0.0.3",
     "@salesforce/ts-sinon": "^1.4.19",
     "@swc/core": "1.3.39",
     "@types/inquirer": "^8.2.0",
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.62.0",
-    "chai": "^4.3.10",
-    "eslint": "^8.53.0",
-    "eslint-config-prettier": "^8.10.0",
-    "eslint-config-salesforce": "^2.0.2",
-    "eslint-config-salesforce-license": "^0.2.0",
-    "eslint-config-salesforce-typescript": "^2.0.0",
-    "eslint-plugin-header": "^3.1.1",
-    "eslint-plugin-import": "2.29.0",
-    "eslint-plugin-jsdoc": "^46.8.2",
     "eslint-plugin-sf-plugin": "^1.16.11",
-    "husky": "^7.0.4",
-    "mocha": "^9.1.3",
-    "nyc": "^15.1.0",
     "oclif": "^3.17.2",
-    "prettier": "^2.8.8",
-    "pretty-quick": "^3.1.0",
     "shx": "0.3.4",
-    "sinon": "10.0.0",
-    "ts-node": "^10.0.0",
-    "typescript": "^5.2.2",
-    "wireit": "^0.14.1"
+    "ts-node": "^10.9.1",
+    "typescript": "^5.2.2"
   },
   "engines": {
     "node": ">=16.0.0"

src/authBaseCommand.ts

@@ -33,7 +33,7 @@ export abstract class AuthBaseCommand<T> extends SfCommand<T> {
   }
 
   protected async shouldExitCommand(noPrompt?: boolean, message?: string): Promise<boolean> {
-    if (noPrompt || Global.getEnvironmentMode() !== Mode.DEMO) {
+    if (Boolean(noPrompt) || Global.getEnvironmentMode() !== Mode.DEMO) {
       return false;
     } else {
       const msg = dimMessage(message ?? messages.getMessage('warnAuth', [this.config.bin]));
@@ -43,7 +43,7 @@ export abstract class AuthBaseCommand<T> extends SfCommand<T> {
   }
 
   protected async shouldRunCommand(noPrompt?: boolean, message?: string, defaultAnswer = true): Promise<boolean> {
-    if (noPrompt || Global.getEnvironmentMode() === Mode.DEMO) {
+    if (Boolean(noPrompt) || Global.getEnvironmentMode() === Mode.DEMO) {
       return true;
     } else {
       const msg = dimMessage(message ?? messages.getMessage('warnAuth', [this.config.bin]));