Skip to content

Commit

Permalink
fix: typescript errors not showing in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
nrkruk committed Nov 20, 2024
1 parent 0449090 commit 845e58c
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 9 deletions.
39 changes: 39 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: build

on:
pull_request:
push:
branches:
- main
- '*-patch'

jobs:
determine-node-versions:
outputs:
nodeVersions: ${{ steps.determine-node-versions.outputs.nodeVersions }}
runs-on: ubuntu-latest
steps:
- uses: salesforcecli/github-workflows/.github/actions/determineNodeVersions@main
id: determine-node-versions
with:
nodeVersionOverride: ${{ vars.NODE_VERSION_OVERRIDE }} # default is 'lts/*' and 'lts/-1'
nodeDisableCurrent: ${{ vars.UT_DISABLE_NODE_CURRENT }} # default is falsy
nodeDisablePrevious: ${{ vars.UT_DISABLE_NODE_PREVIOUS }} # default is falsy

build:
needs: determine-node-versions
strategy:
matrix:
node_version: ${{ fromJSON(needs.determine-node-versions.outputs.nodeVersions) }}
fail-fast: false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node_version }}

- run: yarn install

- run: yarn build
12 changes: 6 additions & 6 deletions .github/workflows/failureNotifications.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: failureNotifications
on:
workflow_dispatch:
# workflow_run:
# workflows:
# - publish
# - create-github-release
# types:
# - completed
workflow_run:
workflows:
- publish
- create-github-release
types:
- completed
jobs:
failure-notify:
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions src/commands/lightning/dev/site.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import fs from 'node:fs';
import { SfCommand, Flags } from '@salesforce/sf-plugins-core';
import { Messages } from '@salesforce/core';
import { expDev, setupDev } from '@lwrjs/api';
import { expDev, LocalDevOptions, setupDev } from '@lwrjs/api';
import { OrgUtils } from '../../../shared/orgUtils.js';
import { PromptUtils } from '../../../shared/promptUtils.js';
import { ExperienceSite } from '../../../shared/experience/expSite.js';
Expand Down Expand Up @@ -80,8 +80,8 @@ export default class LightningDevSite extends SfCommand<void> {

// Start the dev server
const port = parseInt(process.env.PORT ?? '3000', 10);
const startupParams = {
sfCli: true,
const startupParams: LocalDevOptions = {
sfCLI: true,
authToken,
open: true,
port,
Expand Down

0 comments on commit 845e58c

Please sign in to comment.