From bb0c96dfb4c89aa3e34deb34f61554e037853649 Mon Sep 17 00:00:00 2001 From: Willhoit Date: Tue, 24 Sep 2024 10:55:53 -0500 Subject: [PATCH 1/6] fix: add specifier --- messages/package_version_delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messages/package_version_delete.md b/messages/package_version_delete.md index 60fc92e9..cc30c34c 100644 --- a/messages/package_version_delete.md +++ b/messages/package_version_delete.md @@ -46,7 +46,7 @@ The request to delete this package version has been canceled. # humanSuccess -Successfully deleted the package version. +Successfully deleted the package version. %s # humanSuccessUndelete From bcec2af9a4218e674cfc77285f40b6ed361b0e05 Mon Sep 17 00:00:00 2001 From: Eric Willhoit Date: Tue, 24 Sep 2024 11:39:28 -0500 Subject: [PATCH 2/6] fix: another specifier --- messages/package_delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messages/package_delete.md b/messages/package_delete.md index 53a8d2f7..515a68b5 100644 --- a/messages/package_delete.md +++ b/messages/package_delete.md @@ -48,7 +48,7 @@ The request to delete this package was canceled # humanSuccess -Successfully deleted the package. +Successfully deleted the package. %s # humanSuccessUndelete From be0f5c0260d4165c085cf4973bf3c25103c4fccc Mon Sep 17 00:00:00 2001 From: Eric Willhoit Date: Tue, 24 Sep 2024 14:23:57 -0500 Subject: [PATCH 3/6] chore: update human readable output --- messages/package_delete.md | 2 +- messages/package_version_delete.md | 2 +- test/commands/package/packageCreateAndDelete.nut.ts | 2 +- test/commands/package/packageVersion.nut.ts | 2 +- test/commands/package/version.delete.test.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/messages/package_delete.md b/messages/package_delete.md index 515a68b5..880033fa 100644 --- a/messages/package_delete.md +++ b/messages/package_delete.md @@ -48,7 +48,7 @@ The request to delete this package was canceled # humanSuccess -Successfully deleted the package. %s +Successfully deleted the package with id: %s # humanSuccessUndelete diff --git a/messages/package_version_delete.md b/messages/package_version_delete.md index cc30c34c..62b84671 100644 --- a/messages/package_version_delete.md +++ b/messages/package_version_delete.md @@ -46,7 +46,7 @@ The request to delete this package version has been canceled. # humanSuccess -Successfully deleted the package version. %s +Successfully deleted the package version with id: %s # humanSuccessUndelete diff --git a/test/commands/package/packageCreateAndDelete.nut.ts b/test/commands/package/packageCreateAndDelete.nut.ts index 9a91acee..f9ab043f 100644 --- a/test/commands/package/packageCreateAndDelete.nut.ts +++ b/test/commands/package/packageCreateAndDelete.nut.ts @@ -51,7 +51,7 @@ describe('package create/update/delete', () => { it('should delete a package - human readable results', () => { const command = `package:delete -p ${pkgName} -v ${session.hubOrg.username} --no-prompt`; const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout; - expect(output).to.contain('Successfully deleted the package. 0Ho'); + expect(output).to.contain('Successfully deleted the package with id: 0Ho'); }); }); describe('create/update/delete - json results', () => { diff --git a/test/commands/package/packageVersion.nut.ts b/test/commands/package/packageVersion.nut.ts index 9074efbd..cf696dcf 100644 --- a/test/commands/package/packageVersion.nut.ts +++ b/test/commands/package/packageVersion.nut.ts @@ -443,7 +443,7 @@ describe('package:version:*', () => { const id = deletableVersionIds.pop(); const command = `package:version:delete -p ${id} --noprompt`; const result = execCmd<[PackageSaveResult]>(command, { ensureExitCode: 0 }).shellOutput.stdout; - expect(result).to.contain(`Successfully deleted the package version. ${id}`); + expect(result).to.contain(`Successfully deleted the package version with id: ${id}`); }); }); diff --git a/test/commands/package/version.delete.test.ts b/test/commands/package/version.delete.test.ts index 101ea488..95eb89e8 100644 --- a/test/commands/package/version.delete.test.ts +++ b/test/commands/package/version.delete.test.ts @@ -93,7 +93,7 @@ describe('package:version:delete', () => { const results: PackageSaveResult = await command.run(); expect(results.id).to.equal('testId'); expect(uxSuccessStub.calledOnce).to.be.true; - expect(uxSuccessStub.args[0][0]).to.equal('Successfully deleted the package version. testId'); + expect(uxSuccessStub.args[0][0]).to.equal('Successfully deleted the package version with id: testId'); expect(results.id).to.equal('testId'); }); it('should undelete a package version', async () => { From 715fb14230fe1a62386ae6f8727507b4639ec12c Mon Sep 17 00:00:00 2001 From: Willhoit Date: Thu, 26 Sep 2024 15:37:13 -0500 Subject: [PATCH 4/6] chore: suggestion Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com> --- messages/package_delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messages/package_delete.md b/messages/package_delete.md index 880033fa..b0901367 100644 --- a/messages/package_delete.md +++ b/messages/package_delete.md @@ -48,7 +48,7 @@ The request to delete this package was canceled # humanSuccess -Successfully deleted the package with id: %s +Successfully deleted the package with ID: %s # humanSuccessUndelete From 8201c5a2c21026487eebd61e7ad107647ed82896 Mon Sep 17 00:00:00 2001 From: Willhoit Date: Thu, 26 Sep 2024 15:37:44 -0500 Subject: [PATCH 5/6] chore: suggestion Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com> --- test/commands/package/packageCreateAndDelete.nut.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/commands/package/packageCreateAndDelete.nut.ts b/test/commands/package/packageCreateAndDelete.nut.ts index f9ab043f..6ff7e66e 100644 --- a/test/commands/package/packageCreateAndDelete.nut.ts +++ b/test/commands/package/packageCreateAndDelete.nut.ts @@ -51,7 +51,7 @@ describe('package create/update/delete', () => { it('should delete a package - human readable results', () => { const command = `package:delete -p ${pkgName} -v ${session.hubOrg.username} --no-prompt`; const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout; - expect(output).to.contain('Successfully deleted the package with id: 0Ho'); + expect(output).to.contain('Successfully deleted the package with ID: 0Ho'); }); }); describe('create/update/delete - json results', () => { From 3790e17739b7c32510b69ec8d2c3ce05c482da6f Mon Sep 17 00:00:00 2001 From: Willhoit Date: Thu, 26 Sep 2024 15:39:15 -0500 Subject: [PATCH 6/6] chore: suggestion Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com> --- messages/package_version_delete.md | 2 +- test/commands/package/packageVersion.nut.ts | 2 +- test/commands/package/version.delete.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/messages/package_version_delete.md b/messages/package_version_delete.md index 62b84671..43e1688f 100644 --- a/messages/package_version_delete.md +++ b/messages/package_version_delete.md @@ -46,7 +46,7 @@ The request to delete this package version has been canceled. # humanSuccess -Successfully deleted the package version with id: %s +Successfully deleted the package version with ID: %s # humanSuccessUndelete diff --git a/test/commands/package/packageVersion.nut.ts b/test/commands/package/packageVersion.nut.ts index cf696dcf..d4667874 100644 --- a/test/commands/package/packageVersion.nut.ts +++ b/test/commands/package/packageVersion.nut.ts @@ -443,7 +443,7 @@ describe('package:version:*', () => { const id = deletableVersionIds.pop(); const command = `package:version:delete -p ${id} --noprompt`; const result = execCmd<[PackageSaveResult]>(command, { ensureExitCode: 0 }).shellOutput.stdout; - expect(result).to.contain(`Successfully deleted the package version with id: ${id}`); + expect(result).to.contain(`Successfully deleted the package version with ID: ${id}`); }); }); diff --git a/test/commands/package/version.delete.test.ts b/test/commands/package/version.delete.test.ts index 95eb89e8..6e469c07 100644 --- a/test/commands/package/version.delete.test.ts +++ b/test/commands/package/version.delete.test.ts @@ -93,7 +93,7 @@ describe('package:version:delete', () => { const results: PackageSaveResult = await command.run(); expect(results.id).to.equal('testId'); expect(uxSuccessStub.calledOnce).to.be.true; - expect(uxSuccessStub.args[0][0]).to.equal('Successfully deleted the package version with id: testId'); + expect(uxSuccessStub.args[0][0]).to.equal('Successfully deleted the package version with ID: testId'); expect(results.id).to.equal('testId'); }); it('should undelete a package version', async () => {