From f28fd65eccbe12343d0465187454e46c9a4a5689 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Fri, 26 Jul 2024 09:04:38 -0500 Subject: [PATCH] test: remove error name assertions (let SDR handle) --- test/nuts/seeds/deploy.metadata.seed.ts | 3 +-- test/nuts/seeds/retrieve.metadata.seed.ts | 4 +--- test/nuts/seeds/retrieve.retrievetargetdir.seed.ts | 6 ++---- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/test/nuts/seeds/deploy.metadata.seed.ts b/test/nuts/seeds/deploy.metadata.seed.ts index a172fe206..408738766 100644 --- a/test/nuts/seeds/deploy.metadata.seed.ts +++ b/test/nuts/seeds/deploy.metadata.seed.ts @@ -51,8 +51,7 @@ context('Deploy metadata NUTs [name: %REPO_NAME%]', () => { } it('should throw an error if the metadata is not valid', async () => { - const deploy = await testkit.deploy({ args: '--metadata DOES_NOT_EXIST', exitCode: 1 }); - testkit.expect.errorToHaveName(deploy ?? {}, 'SfError'); + await testkit.deploy({ args: '--metadata DOES_NOT_EXIST', exitCode: 1 }); }); it('should not deploy metadata outside of a package directory', async () => { diff --git a/test/nuts/seeds/retrieve.metadata.seed.ts b/test/nuts/seeds/retrieve.metadata.seed.ts index e0c0a36fe..b1d44a260 100644 --- a/test/nuts/seeds/retrieve.metadata.seed.ts +++ b/test/nuts/seeds/retrieve.metadata.seed.ts @@ -8,7 +8,6 @@ import path from 'node:path'; import { fileURLToPath } from 'node:url'; import { SourceTestkit } from '@salesforce/source-testkit'; -import { JsonMap } from '@salesforce/ts-types'; import { RepoConfig, TEST_REPOS_MAP } from '../testMatrix.js'; // DO NOT TOUCH. generateNuts.ts will insert these values @@ -70,8 +69,7 @@ context('Retrieve metadata NUTs [name: %REPO_NAME%]', () => { } it('should throw an error if the metadata is not valid', async () => { - const retrieve = (await testkit.retrieve({ args: '--metadata DOES_NOT_EXIST', exitCode: 1 })) as JsonMap; - testkit.expect.errorToHaveName(retrieve, 'SfError'); + await testkit.retrieve({ args: '--metadata DOES_NOT_EXIST', exitCode: 1 }); }); }); }); diff --git a/test/nuts/seeds/retrieve.retrievetargetdir.seed.ts b/test/nuts/seeds/retrieve.retrievetargetdir.seed.ts index b6622021f..f693c0d42 100644 --- a/test/nuts/seeds/retrieve.retrievetargetdir.seed.ts +++ b/test/nuts/seeds/retrieve.retrievetargetdir.seed.ts @@ -7,7 +7,6 @@ import { fileURLToPath } from 'node:url'; import { SourceTestkit } from '@salesforce/source-testkit'; -import { JsonMap } from '@salesforce/ts-types'; import { RepoConfig, TEST_REPOS_MAP } from '../testMatrix.js'; // DO NOT TOUCH. generateNuts.ts will insert these values @@ -45,11 +44,10 @@ context('Retrieve metadata NUTs [name: %REPO_NAME%]', () => { } it('should throw an error if the metadata is not valid', async () => { - const retrieve = (await testkit.retrieve({ + await testkit.retrieve({ args: '--retrievetargetdir targetdir --metadata DOES_NOT_EXIST', exitCode: 1, - })) as JsonMap; - testkit.expect.errorToHaveName(retrieve, 'SfError'); + }); }); }); });