-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import YAML with context #56
Conversation
@Lucianovici could you update both commit messages to comply with conventional commit standard. |
@noelmcloughlin Is it important to fix this? The solution of renaming pushed commit messages is not ideal (forcing to push) - is there another way I am not aware of? |
Yes. All automation based on conventional commits (widely used today instead of unconventional commits) breaks. Someone would have to change those commit messages to get CI and Semantic Release working. |
@noelmcloughlin Since I am a casual committer, can we do as advice here please? |
I'm not maintainer, just passing by, so its extra workload. I think its possible, I've never done that, I could try I guess. Lines 11 to 12 in 79081c9
|
Okay, that did not work, I'll try to remember to open a new PR to fix your commit messages. Please use conventional commits in future, its considered impolite to use unconventional commits these days. |
Alright thank you, I will use the convention from now on. But why didn't it work, I just alter the history and force push it. |
Just noting that this is an example of a patch for this Salt regression as mentioned here: We may want to revert the |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Import with context to avoid errors like: