Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure config precedence is correct #112

Open
twangboy opened this issue Oct 8, 2021 · 2 comments
Open

Ensure config precedence is correct #112

twangboy opened this issue Oct 8, 2021 · 2 comments

Comments

@twangboy
Copy link
Contributor

twangboy commented Oct 8, 2021

minion_id
overridden by minion config file
overridden by config in minion.d <==== Not sure about this one
@marbx
Copy link
Contributor

marbx commented Nov 3, 2021 •
edited
Loading

The minion_id file is not yet tested and lacks a test case.

The only implementation detail is

salt-windows-msi/tests/config_tests/test.ps1

Line 102 in 6fd6566

Copy-Item -Path $minion_id -Destination "C:\ProgramData\Salt Project\Salt\conf\minion_id"

@marbx
Copy link
Contributor

marbx commented Nov 3, 2021

Precedence is defined by the order ReadConfig_IMCAC(Session session) reads configuration

salt-windows-msi/CustomAction01/CustomAction01.cs

Line 20 in 6fd6566

public static ActionResult ReadConfig_IMCAC(Session session) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marbx @twangboy